| Summary: | grouping windows should unhide the titlebar | ||
|---|---|---|---|
| Product: | [Plasma] Oxygen | Reporter: | qqqqqqqqq9 |
| Component: | win deco | Assignee: | Hugo Pereira Da Costa <hugo.pereira.da.costa> |
| Status: | REPORTED --- | ||
| Severity: | wishlist | CC: | hugo.pereira.da.costa, kwin-bugs-null |
| Priority: | NOR | ||
| Version: | 4.0 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Without titlebar
with title Shaded window without titlebar |
||
|
Description
qqqqqqqqq9
2010-12-20 19:01:40 UTC
how do you shade a window without titlebar? I just set "no border" and shade is not available any more... Either via shortcut that can be set, or through the window actions menu (Alt+F3). With border but no title Shading and Unshading itself works flawless. After shading i end up with just the border and no window in it. This takes fokus and can be easily unshaded again. Sorry, but I do not get what you mean. When I disable borders I cannot shade the window through Alt+F3. It is disabled. Furthermore I do not get what the difference between "border" and "title" is for you. I assumed you mean the same with it, but then your last comment does not make sense at all. client.cpp:715
--------------
bool Client::userCanSetNoBorder() const
{
return !isFullScreen() && !isShade() && ( clientGroup() == NULL || !(clientGroup()->items().count() > 1));
}
void Client::setNoBorder( bool set )
{
if( !userCanSetNoBorder() )
return;
client.cpp:983
-------------
bool Client::isShadeable() const
{
return !isSpecialWindow() && !noBorder();
}
void Client::setShade( ShadeMode mode )
{
if( !isShadeable())
return;
.....
-> borderless windows cannot be shaded and shaded windows cannot be un-bordered.
Please ensure you're actually using kwin and not compiz.
Created attachment 55111 [details]
Without titlebar
Created attachment 55112 [details]
with title
Who is talking about border???? I am talking about windows with borders but without titlebars (see attached pictures). Created attachment 55113 [details]
Shaded window without titlebar
ahhh, ok - you're talking about the "proprietary" rules of the oxygen decoration?!? (kwin in general supports borders - it doesn't care about what the decoration plugin does/looks on them) So this isn't the right place for this feature request? I sure like the feature to hide the title bar and would love to see those glitches be smoothed out. Wher sould i report it? > Where sould i report it?
done. Sorry for the noise but we thought about an entirely different thing ;-)
Will fix :) (but to-morrow) @ Thomas Lübking Thanks for fixing my typos ;) @ Hugo Pereira Da Costa Great :D. A similar problem arises with titlebar tabbing. When a window has more than one tab, automatically unhiding the titlebar seems to be a good idea, too. @qqqqqqq(etc) Agreed. I figured the issue with tabbing also. Actually I have the shading part fixed here (and I'm about to push to trunk) However, the tabbing is more complicated, because unhiding/hiding the titlebar affects the layout metrics (Client::LayoutMetric), and the window layout is not reset properly when tabbing (so that the corresponding changes are not accounted for in the tabbed group). SVN commit 1208187 by hpereiradacosta: Properly account for window's shaded state, and number of clients in groups when deciding whether or not the titlebar should be hidden. This is half the job, cause the above does not work (yet) when grouping windows among which one has hidden titlebar. Shading works well now, though. CCBUG: 260815 M +1 -1 oxygenbutton.cpp M +7 -7 oxygenclient.cpp M +11 -1 oxygenclient.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1208187 PS: interesting color style :) Hi, didn't have time to test it till now, but it works great. :D Very useful on small screens. Thanks a lot. renamed bug to reflect the "second" bug (grouping) that is still there. |