Bug 260754

Summary: dngconverter doesn't support sraw files
Product: [Applications] digikam Reporter: krzysztof pijarski <kpijarski>
Component: Plugin-Bqm-DngConverterAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, lexa, tschenser
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In: 2.0.0

Description krzysztof pijarski 2010-12-20 01:32:10 UTC 
Version:           1.8.0 (using KDE 4.5.1) 
OS:                Linux

dngconverter doesn't support sraw files - tested on Canon 5dmkII. As I understand it the problem lies in the fact that sraw files are already demosaiced, but still - they are legitimate (are they?) raw files. AFAIK Adobe's dng converter does support them.
Are there any plans do have this here?

Reproducible: Always

Steps to Reproduce:
try to convert an sraw file

Actual Results:  
the conversion fails

Expected Results:  
dngconverter should produce a valid dng file
Comment 1 caulier.gilles 2010-12-20 06:52:54 UTC 
Alex, do you know SRAW files ?

Gilles Caulier
Comment 2 Alex Tutubalin 2010-12-20 07:31:08 UTC 
Canon's sRAW (both sRAW1 and sRAW2) are supported by LibRaw. The internal YCC channels are splitted back to RGB data during unpack stage.

The unprocessed unpacked data contains only three channels, the second G(reen) channel is empty.
Comment 3 Jens Mueller 2010-12-22 08:15:51 UTC 
With Canon sRaw the main image is coded as LinearRaw in the generated dng file. Dngconverter does currently not support LinearRaws. As Alex said that he convert the internal YCC to RGB it should be possible to this.
Comment 4 Jens Mueller 2011-01-27 21:06:19 UTC 
Alex,

how do sraw differ from cfa in libraw params? As far as I can see imgdata.idata.colors is 3 in both cases. The only thing I see is imgdata.idata.filters, which is zero for sraw. Is this the hint?

Jens
Comment 5 Alex Tutubalin 2011-01-27 21:43:10 UTC 
Yes, filters == 0 for already interpolated data (including sRAW and 4-shot Sinars). So, all three channels are filled in every pixel.
Comment 6 Jens Mueller 2011-03-01 23:06:50 UTC 
Git commit 860b3c3a238fba36999555832013aff1ca3a0094 by Jens Mueller.
Committed on 01/03/2011 at 23:03.
Pushed by jmueller into branch 'master'.

add canon sraw to linear dng conversion

BUGS: 260754

M  +205  -177  dngconverter/dngwriter/dngwriter.cpp     
M  +1    -1    dngconverter/plugin/aboutdata.h     

http://commits.kde.org/kipi-plugins/860b3c3a238fba36999555832013aff1ca3a0094