Summary: | Konqueror crashed when loading few web pages opened from Plasma rss news widget | ||
---|---|---|---|
Product: | [Frameworks and Libraries] kwebkitpart | Reporter: | Marko Hänninen <bugitus> |
Component: | general | Assignee: | webkit-devel |
Status: | RESOLVED WORKSFORME | ||
Severity: | crash | CC: | adawit, andresbajotierra |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Marko Hänninen
2010-12-18 11:36:32 UTC
[Comment from a bug triager] This looks related to bug 253340 and or bug 247311, so it could be fixed for KDE SC 4.6 Regards This makes no sense. The fix for this crash has been backported prior to the release of KDE 4.5.4. Specifically the crash at the following location Thread 1 (Thread 0x7f2347053760 (LWP 9727)): [KCrash Handler] #6 0x0000000000000000 in ?? () #7 0x00007f233d6cd1d7 in WebCore::QNetworkReplyHandler::forwardData (this=0x1ee8f20) at platform/network/qt/QNetworkReplyHandler.cpp:399 should only occur for the version of Qt you are using for versions of KDE where we incorrectly returned a NULL network reply pointer when we were unable to handle the requested operation. Returning a NULL causes QtWebKit to crash at line #399 because it does not check for a NULL pointer as can be seen in the link below: http://gitorious.org/+qtwebkit-developers/webkit/qtwebkit/blobs/qtwebkit-2.0/WebCore/platform/network/qt/QNetworkReplyHandler.cpp Since you compiled from source, can you please check to make sure the version of kdelibs/kio/kio/accessmanager.cpp you have, specially the default switch handler case (lines #167-171) matches the lines from the source code below: http://websvn.kde.org/tags/KDE/4.5.4/kdelibs/kio/kio/accessmanager.cpp?revision=1193669&view=markup (In reply to comment #2) > Since you compiled from source, can you please check to make sure the version > of kdelibs/kio/kio/accessmanager.cpp you have, specially the default switch > handler case (lines #167-171) matches the lines from the source code below: > > http://websvn.kde.org/tags/KDE/4.5.4/kdelibs/kio/kio/accessmanager.cpp?revision=1193669&view=markup Yes, they are exactly the same versions. I downloaded accessmanager.cpp from your url and diffed it with my sources. Also md5sums were same: 74e3e4b02c4b4855cd717bcfc0f3d451. Maybe webkit should be patched to check null pointer? On the other hand that won't fix the originating problem, only hides it... (In reply to comment #3) > (In reply to comment #2) > > > Since you compiled from source, can you please check to make sure the version > > of kdelibs/kio/kio/accessmanager.cpp you have, specially the default switch > > handler case (lines #167-171) matches the lines from the source code below: > > > > http://websvn.kde.org/tags/KDE/4.5.4/kdelibs/kio/kio/accessmanager.cpp?revision=1193669&view=markup > > Yes, they are exactly the same versions. I downloaded accessmanager.cpp from > your url and diffed it with my sources. Also md5sums were same: > 74e3e4b02c4b4855cd717bcfc0f3d451. > > Maybe webkit should be patched to check null pointer? On the other hand that > won't fix the originating problem, only hides it... That is just it... We do not return a NULL reply pointer anymore starting with KDE 4.5.4 ; so the crash should not be because of that. The only difference in your backtrace is that there is an additional unknown code path hit before the crash, i.e. the [KCrash Handler] #6 0x0000000000000000 in ?? () so it might be a different cause for the crash, but still without being able to duplicate the issue or somehow find a way to reproduce it, I dunnot what to tell you... Is this issue still valid ? I have been unable to reproduce after the original fix that was committed prior to 4.5.4. (In reply to comment #5) > Is this issue still valid ? I have been unable to reproduce after the original > fix that was committed prior to 4.5.4. Sorry that it took so long time to reply. The problem seems to be vanished with some update, but I can't tell which one. Right now I'm using KDE 4.6.3 with QT 4.7.3 and everything is working again =) Thanks for investigating the issue! |