Bug 260494

Summary: Minimised dockers has a fixed width messing with other dockers
Product: [Applications] calligracommon Reporter: Kubuntiac <user581>
Component: generalAssignee: Calligra Bugs <calligra-bugs-null>
Status: RESOLVED DUPLICATE    
Severity: normal CC: cbo, halla
Priority: NOR    
Version: 2.0   
Target Milestone: ---   
Platform: unspecified   
OS: Unspecified   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Minimised dockers in the current revision - please compare to the mockup image
How minimised dockers appear on opening
How dockers appear after unminimise and then minimise

Description David Faure 2010-12-17 19:41:15 UTC


---- Reported by bugsbane@gmail.com 2009-07-22 23:08:45 ----

Version:            (using KDE 4.2.98)

When dockers are minimised, they shrink horizontally as well as vertically, hiding their name, what they do and their keyboard shortcut, even when there is blank space next to them.

See this image:
http://www.freeimagehosting.net/uploads/b14aa17557.png


I'm guessing that they should shrink vertically to just the name / shortcut, but still use the full width of the docker panel, as in this immage (mocked up in Krita for bonus points :-)
http://www.freeimagehosting.net/uploads/3788c2960b.png



---- Additional Comments From zander@kde.org 2010-11-20 14:09:59 ----

SVN commit 1199040 by zander:

Fix Minimised dockers are hiding name.

Patch from Rahul Das, thanks a lot for fixing this issue :)

BUG: 201160
CCMAIL: h.rahuldas@gmail.com

 M  +7 -1      KoDockWidgetTitleBar.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1199040



---- Additional Comments From bugsbane@gmail.com 2010-11-20 21:40:09 ----

Created an attachment
Minimised dockers in the current revision - please compare to the mockup image

Awesome. All glory to the hypnoto...er Rahul!

On r1199143 it now at least doesn't cut the name off, but it still isn't using the available width like un-minimised dockers do, which looks strange. (See attached picture for details).

We're so very close to having this perfect. Any chance of just updating the width calculation to just be 100% of the docker column as in the mockup image above?



---- Additional Comments From bugsbane@gmail.com 2010-11-21 06:00:00 ----

Created an attachment
How minimised dockers appear on opening

I also just discovered a glitch in this... when first opening Krita (and maybe other koffice apps) with minimised dockers, this patch doesn't seem to fix *any* of the issue. Labels still get cut off. docker-on-open.png demonstrates how dockers appear on first opening Krita r1199143.

If I unminimise a docker and minimise it again, then the text ceases to be cut off (although it's still not full width). See docker-after-unminimise-and-minimise.png for this state.



---- Additional Comments From bugsbane@gmail.com 2010-11-21 06:00:38 ----

Created an attachment
How dockers appear after unminimise and then minimise



---- Additional Comments From bugsbane@gmail.com 2010-11-21 06:02:21 ----

Ideally though, dockers should *always* take the full column width when minimised... just as they do when they're maximised.



---- Additional Comments From zander@kde.org 2010-11-21 12:45:56 ----

Whats the reason for you reopening the bug? The issue got fixed. The shortcut can be read, the text can be read.
I see you wanted it to be full width but is that really reason for reopening the bug?



---- Additional Comments From bugsbane@gmail.com 2010-11-21 19:01:26 ----

By shortcut I'm assuming you mean the title at the top of the docker, in which case, no it can't be read if the docker is minimised when you first open Krita.

1. See http://bugsfiles.kde.org/attachment.cgi?id=53598 and look at the title of the second docker in that image. This is how dockers currently show up (after the patch) if minimised when Krita is first opened. They only show the full text if you maximise them and then minimise them again.

2. The title of this original issue starts with "Minimised dockers don't use available width". Look at any of the attatched images. Under no circumstances are minimised dockers using the available width.



--- Bug imported by faure@kde.org 2010-12-17 19:42  ---

This bug was previously known as bug 201160.

Imported an attachment (id=54926)
Imported an attachment (id=54927)
Imported an attachment (id=54928)

The original submitter of attachment 54926 [details] is unknown.
   Reassigning to the person who moved it here: faure@kde.org.
The original submitter of attachment 54927 [details] is unknown.
   Reassigning to the person who moved it here: faure@kde.org.
The original submitter of attachment 54928 [details] is unknown.
   Reassigning to the person who moved it here: faure@kde.org.

Comment 1 Camilla Boemann 2012-04-16 16:03:31 UTC
Bah it's even worse now. Now the docker forces all other dockers to have miimum width.

Do people still use this minimize button or can we remove it,?
Comment 2 Halla Rempt 2012-04-16 16:07:06 UTC
I'm actually fine with removing it. I know we put a lot of work in it, but I've never seen a user actually use the feature. But this needs to be discussed with all of the calligra developers.
Comment 3 Halla Rempt 2012-04-16 16:11:35 UTC

*** This bug has been marked as a duplicate of bug 297327 ***