Bug 260402

Summary:	Not acceptable behaviour in message renaming in collaboration diagrams
Product:	[Applications] umbrello	Reporter:	kpsychas
Component:	general	Assignee:	Ralf Habacker <ralf.habacker>
Status:	RESOLVED FIXED
Severity:	minor	CC:	ralf.habacker
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:	http://commits.kde.org/umbrello/b79841266e8c07c89dbfa5934570ca5c3c434bf9	Version Fixed In:	4.13.0
Sentry Crash Report:

Description kpsychas 2010-12-17 19:36:27 UTC

Version:           unspecified
OS:                Linux

When attempting to change a message name of a collaboration diagram with a sequence number specified
e.g 1:name, or even when no number appears then
"1:" or ":" is appended to the original name
Also the position of message name is restored to its default (the position when it was created)

Reproducible: Always

Steps to Reproduce:
Select a message in collaboration diagram
Move it to a position other than its initial one
Select "Select Operation..."
Choose OK

Actual Results:  
message's sequence number and ":" appended to its name and its position restored to default

Expected Results:  
Nothing

Comment 1 Ralf Habacker 2014-03-29 08:34:22 UTC

Git commit 3e468a9e1d3a9581922f890b14456b493392b28f by Ralf Habacker.
Committed on 26/03/2014 at 18:41.
Pushed by habacker into branch 'master'.

Show operation dialog on creation of collaboration diagram messages to keep in sync with sequence diagrams.

M  +3    -0    umbrello/toolbarstateassociation.cpp

http://commits.kde.org/umbrello/3e468a9e1d3a9581922f890b14456b493392b28f

Comment 2 Ralf Habacker 2014-03-29 08:34:22 UTC

Git commit b4462ac623929b364196d86734e9a78d354ac699 by Ralf Habacker.
Committed on 27/03/2014 at 19:55.
Pushed by habacker into branch 'master'.

Move MessageWidget class member sequence number and related methods to base class LinkWidget.

M  +36   -0    umbrello/widgets/linkwidget.cpp
M  +8    -0    umbrello/widgets/linkwidget.h
M  +4    -18   umbrello/widgets/messagewidget.cpp
M  +0    -4    umbrello/widgets/messagewidget.h

http://commits.kde.org/umbrello/b4462ac623929b364196d86734e9a78d354ac699

Comment 3 Ralf Habacker 2014-03-29 08:34:22 UTC

Git commit 9bdfb1b73cc2e27729892d79c2cf41ae35b9cfa6 by Ralf Habacker.
Committed on 26/03/2014 at 19:39.
Pushed by habacker into branch 'master'.

Show newly created operation in collaboration diagram message to keep in sync with sequence diagrams.

M  +2    -0    umbrello/widgets/associationwidget.cpp

http://commits.kde.org/umbrello/9bdfb1b73cc2e27729892d79c2cf41ae35b9cfa6

Comment 4 Ralf Habacker 2014-03-30 00:00:02 UTC

Git commit 31e0ede3132ed0164ce01a53500cfdb72cb11223 by Ralf Habacker.
Committed on 27/03/2014 at 19:55.
Pushed by habacker into branch 'KDE/4.13'.

Move MessageWidget class member sequence number and related methods to base class LinkWidget.

M  +36   -0    umbrello/widgets/linkwidget.cpp
M  +8    -0    umbrello/widgets/linkwidget.h
M  +4    -18   umbrello/widgets/messagewidget.cpp
M  +0    -4    umbrello/widgets/messagewidget.h

http://commits.kde.org/umbrello/31e0ede3132ed0164ce01a53500cfdb72cb11223

Comment 5 Ralf Habacker 2014-03-30 00:00:07 UTC

Git commit 6037b8b26d853810020f271ac4dc98719f4daed1 by Ralf Habacker.
Committed on 26/03/2014 at 17:46.
Pushed by habacker into branch 'KDE/4.13'.

Add sequence number to class AssociationWidget required for collaboration diagram messages.

M  +12   -7    umbrello/widgets/associationwidget.cpp

http://commits.kde.org/umbrello/6037b8b26d853810020f271ac4dc98719f4daed1

Comment 6 Ralf Habacker 2014-03-30 00:00:16 UTC

Git commit cd4dfeb430c61b196370c02e1ea5c2a21668d62f by Ralf Habacker.
Committed on 26/03/2014 at 18:40.
Pushed by habacker into branch 'KDE/4.13'.

Keep auto increment sequence support of collaboration diagrams in sync with sequence diagrams.

M  +4    -2    umbrello/dialogs/diagrampropertiespage.cpp
M  +15   -5    umbrello/umlscene.cpp

http://commits.kde.org/umbrello/cd4dfeb430c61b196370c02e1ea5c2a21668d62f

Comment 7 Ralf Habacker 2014-03-30 00:00:25 UTC

Git commit 72b99f99d5880160d36aea51f43be9c1d5f5c030 by Ralf Habacker.
Committed on 26/03/2014 at 18:41.
Pushed by habacker into branch 'KDE/4.13'.

Show operation dialog on creation of collaboration diagram messages to keep in sync with sequence diagrams.

M  +3    -0    umbrello/toolbarstateassociation.cpp

http://commits.kde.org/umbrello/72b99f99d5880160d36aea51f43be9c1d5f5c030

Comment 8 Ralf Habacker 2014-03-30 00:27:26 UTC

Git commit b79841266e8c07c89dbfa5934570ca5c3c434bf9 by Ralf Habacker.
Committed on 26/03/2014 at 19:39.
Pushed by habacker into branch 'KDE/4.13'.

Show newly created operation in collaboration diagram message to keep in sync with sequence diagrams.

M  +2    -0    umbrello/widgets/associationwidget.cpp

http://commits.kde.org/umbrello/b79841266e8c07c89dbfa5934570ca5c3c434bf9