Summary: | Crash on deleting snow shader | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Daniel Lipowicz <daniel.lipowicz> |
Component: | compositing | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | crash | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | reset mShader |
Description
Daniel Lipowicz
2010-12-09 20:14:44 UTC
Created attachment 54371 [details]
reset mShader
could be memory corruption, but could be confusion about the mActive state, so i guess that accomplishing "delete mShader;" by "mShader = NULL;" won't harm =)
-> ok to commit?
@Daniel
can you somehow reproduce the issue?
> could be memory corruption, but could be confusion about the mActive state,
> so i guess that accomplishing "delete mShader;" by "mShader = NULL;" won't
> harm =) -> ok to commit?
seems safe to go in, though I doubt that this was causing it.
Anyway I just looked at the code and realized I have to rewrite it for ES :-(
SVN commit 1204966 by luebking: reset mShader after deletion CCBUG: 259362 M +1 -0 snow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1204966 no, could be pretty much everything (the nasty thing about memory corruptions) - just looked suspicous. Yes, the problem is when you want to run snow effect
W dniu 09.12.2010 21:42, Thomas Lübking pisze:
> can you somehow reproduce the issue?
>
Everytime?(??) Since the particular code should actually not be called on activating the snow effect there might be some sort of double trigger (hanging key or whatever) within two frames (so that once the shader got deleted & invalidated, there's been no occasion to recreate it in paintScreen() after the toggle/on and before the successive toggle/off) @Daniel: can you compile in the patch and see whether the issue is gone? Git commit 3e8c9a65e2b165cd153ac15ccb59e30880de9258 by Martin Gr����lin. Pushed by graesslin into branch 'graesslin/kwin-cleanup'. Removing Snow Effect. The usefulness of the snow effect is doubtable and it is rather difficult to port the effect to the new rendering architecture introduced with GLES. It is probably easier to rewrite the complete effect from scratch, therefore it is removed for now. I might consider readding it for 4.7. This kind of "fixes" snow related bug reports. BUG: 259362 BUG: 254498 FIXED-IN: 4.7.0 M +0 -3 kwin/effects/CMakeLists.txt M +0 -6 kwin/effects/configs_builtins.cpp D +0 -33 kwin/effects/snow/CMakeLists.txt D +0 -33 kwin/effects/snow/data/snow.frag D +0 -47 kwin/effects/snow/data/snow.vert D +0 -450 kwin/effects/snow/snow.cpp D +0 -171 kwin/effects/snow/snow.desktop D +0 -107 kwin/effects/snow/snow.h D +0 -138 kwin/effects/snow/snow_config.cpp D +0 -86 kwin/effects/snow/snow_config.desktop D +0 -59 kwin/effects/snow/snow_config.h D +0 -200 kwin/effects/snow/snow_config.ui http://commits.kde.org/a5d5b61a/3e8c9a65e2b165cd153ac15ccb59e30880de9258 |