Bug 258254

Summary: KMail selects too many messages when Shift-clicking the beginning of a thread after one message was deleted
Product: [Unmaintained] kmail Reporter: Tilghman Lesher <kde-org>
Component: message listAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED UNMAINTAINED    
Severity: normal CC: stephane.ascoet
Priority: NOR    
Version: 1.13.2   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: kmail selects bad messages in some cases(bug 258254)

Description Tilghman Lesher 2010-11-29 08:05:50 UTC 
Version:           1.13.2 (using KDE 4.4.2) 
OS:                Linux

One too many messages are selected after deleting a message, then Shift-clicking the first message in a thread.  Typically, this key pattern is used when deleting an entire thread after reading the messages in order.  This could, if the user is not aware of the issue, result in a message being prematurely removed to the Deleted folder (and possibly missed before emptying the Deleted folder).

Reproducible: Always

Steps to Reproduce:
1. Find a set of threaded messages where you can delete the second to last message without distorting the thread.  The shortest example is 3 messages, where the second and third are both replies to the original message.  There should additionally be at least one message following the thread.
2. Delete the second to last message, using the Del key.  You should note that the
last message is now highlighted in the message index.
3. Hold down the shift key and click on the first message in the thread, to select the entire thread.
4. Three messages are now selected:  the two remaining messages in the thread, but ALSO the message AFTER the thread: one beyond the last message that was highlighted.


Expected Results:  
Only the range from the last message selected to the message shift-clicked should have been selected.  In the example above, this should be two messages selected, not three.

OS: Linux (i686) release 2.6.32-25-generic
Compiler: cc
Comment 1 Tilghman Lesher 2010-11-29 08:12:19 UTC 
Hah, apparently this happens, even if you aren't using threading.  Delete any message in a list, then shift click any message above it, and one too many messages will be highlighted.
Comment 2 Stéphane Ascoët 2011-08-30 14:01:51 UTC 
Created attachment 63236 [details]
kmail selects bad messages in some cases(bug 258254)

This picture shows what appends when doing the second selection:
I have shift-clicked on the last "icones" message, however messages between the first and this one aren't selected. Even worse, the message below is selected, thought I never asked this!
Comment 3 Stéphane Ascoët 2011-08-30 14:04:05 UTC 
Behavior relative to attached picture, a little different from the original bug related case:
Shift-click on several messages a time, and delete them. Do it again: some messages that are inside the area aren't selected, but others may are...
Comment 4 Laurent Montel 2015-04-12 10:08:04 UTC 
Thank you for taking the time to file a bug report.

KMail2 was released in 2011, and the entire code base went through significant changes. We are currently in the process of porting to Qt5 and KF5. It is unlikely that these bugs are still valid in KMail2.

We welcome you to try out KMail 2 with the KDE 4.14 release and give your feedback.