| Summary: | Build fails on XP due to line too long | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Andrew Goodbody <ajg02> |
| Component: | Portability-Compilation | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED INTENTIONAL | ||
| Severity: | normal | CC: | caulier.gilles |
| Priority: | NOR | ||
| Version: | 1.6.0 | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | Version Fixed In: | 7.5.0 | |
| Sentry Crash Report: | |||
| Attachments: |
Possible fix
2nd attempt at patch Updated patch |
||
There is a thread about this subject here : http://www.digikam.org/drupal/node/550#comment-19641 Gilles Caulier Andi, I think it's a side-effect of your last patch about to create local static lib to compile digiKam. Right ? Gilles Caulier Hm maybe, but not because of the static lib, it could be because we have one single INCLUDE_DIRS in the root CMakeLists file. Andi, Do you have take a look on the patch attached ? It's fine for you ? It's not in the opposite way than your last changes about local static libs used during compilation ? Gilles Caulier Yes, it is reverting my changes, but if Windows isn't capable of handling these compile strings, I guess we need to remove the INCLUDE_DIRS from the main CMakeLists file again. Andi, This is Windows XP specific issue. Windows 7 do not have this problem... Gilles Caulier Andi, If the patch is fine for you, well, i will apply it on svn Gilles Caulier Well if it compiles, it is ok :-) CMakeLists will get a little bit more complicated again, but if Windows is too bad at handling longer command line args... so we can apply the patch of course. What I don't like about the patch is that now some include dirs are in the main CMakelists file, the others are in the CMakelists file of the subproject folder. This is even more complicated as it was before. We should put all the include dirs in the subfolders and remove them from the main CMakelists file... Andrew, Can you adapt your patch following comments #9 from Andi ? Thanks in advance Gilles Caulier Note: I cannot check WINXP compilation. All computer there have been migrated under Seven, and all compile fine as well. OK, I will make an attempt but I am no CMake expert. Created attachment 53931 [details]
2nd attempt at patch
Patch created as per Andi's comments
Created attachment 55148 [details]
Updated patch
2nd version of patch had bit-rotted so here is an update. Any chance of getting this committed?
Andi, About Andrew patch, we must to take a choice. It's fine for you or it let's code less readable as the current one. Personally i prefer a good readability. Using a common place to declare includes sound better. An finally XP will disappear progressively. Your viewpoint ? Gilles Caulier ok, i choice... Gilles Caulier |
Created attachment 53752 [details] Possible fix Version: 1.6.0 (using Devel) OS: MS Windows I get Scanning dependencies of target digikam-svnversion [ 0%] Generating digikam/svnversion.h [ 0%] Built target digikam-svnversion Scanning dependencies of target ExternalDraw_automoc Generating externaldraw.moc [ 0%] Built target ExternalDraw_automoc Scanning dependencies of target ExternalDraw [ 0%] Building CXX object libs/imageproperties/markerclusterholderplugin/CMakeFiles/ExternalDraw.dir/ExternalDraw_automoc.obj The input line is too long. The generated command line is well over 8300 characters and the limit is 8191. Reproducible: Always Steps to Reproduce: Build on WinXP