Summary: | Monitor for Activity option triggers notification regardless of window focus | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | ietc |
Component: | monitoring | Assignee: | Konsole Developer <konsole-devel> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | adaptee, bugs.kde.org, martin.sandsmark, simonandric5 |
Priority: | NOR | ||
Version: | 2.8 | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/konsole/7592e8947fde4842a8fe966ec6b9e3fb2c8ccd3b | Version Fixed In: |
Description
ietc
2010-11-24 03:51:47 UTC
I think issue #2 is really a bug, or at least a regression compared with KDE3 konsole. The KDE3 konsole does trigger notification for activity more than once, but limits the rate of such notifications. I guess that is to avoid the flooding of such notifications in a short time. 15s seems the minimum interval between two activity notifications. This issue is not hard to fix. Issue #1 also sounds sensible. However, I think it looks more like improvement than bug and is harder to implement correctly. Git commit 277038478be8d35b82450e9ba5ce584079a0282a by Jekyll Wu. Committed on 21/10/2011 at 06:36. Pushed by jekyllwu into branch 'master'. Allow activity notification to be triggered more than once. The activity notification is now masked for a while after it is triggered. That is basically what KDE3 konsole does. The mask interval is intended to avoid the flooding of notification and is hardcoded as 15 seconds at the moment. Maybe that interval should be user configurable. FIXED-IN:4.8 CCBUG: 257752 M +15 -0 src/Session.cpp M +2 -0 src/Session.h http://commits.kde.org/konsole/277038478be8d35b82450e9ba5ce584079a0282a Thanks for looking into this. I look forward to using your fix. As for issue-1, is it troublesome to check whether the window has focus before triggering; or would doing so break the notification model? changing title, version and severity to reflect the fact that issue #2 has been fixed since KDE SC 4.8 From comment 2: "Maybe that interval should be user configurable." I agree and I raised this in bug 357974. Git commit 7592e8947fde4842a8fe966ec6b9e3fb2c8ccd3b by Martin T. H. Sandsmark. Committed on 06/07/2016 at 22:12. Pushed by sandsmark into branch 'master'. Don't show activity/silence notifications when the terminal is active REVIEW: 128239 M +9 -0 desktop/konsole.notifyrc M +27 -7 src/Session.cpp http://commits.kde.org/konsole/7592e8947fde4842a8fe966ec6b9e3fb2c8ccd3b |