Summary: | Dolphin doesn't walk through the file list with very long file names in Details View using arrow keys. | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | slavrn |
Component: | general | Assignee: | Peter Penz <peter.penz19> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | frank78ac |
Priority: | NOR | Keywords: | investigated |
Version: | 16.12.2 | ||
Target Milestone: | --- | ||
Platform: | Debian stable | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 4.5.4 | |
Sentry Crash Report: |
Description
slavrn
2010-11-20 11:26:30 UTC
Thanks for the bug report! I can confirm both issues in 4.4.4 (Opensuse). I think we've had a report about the first one already, but I can't find it at the moment. The first issue (file with long name is not selected) appears to be fixed in 4.5.x and trunk. The second issue (selection/current item jumps to the top) is still present in 4.5 and trunk. I'm pretty sure I know what the cause of the bug is - in DolphinDetailsView::visualRect(...), the width is replaced by the width of the file name, but this causes problems because this may be wider than the "Name" column. Qt uses the center of the visual rect internally to keep track of the current item, and if the center of the visualRect is outside the "Name" column, it goes wrong. Will try to fix it later today or tomorrow. Small correction: the first issue is not fixed yet. I just didn't see it first because the column width settings were different for my 4.5 branch and trunk users. I'll commit a fix for both issues in a minute SVN commit 1199123 by freininghaus: Make sure that an item's visualRect in the Details View is not wider than the "Name" column. Fixes keyboard navigation problems if files with very wide names are present in the current folder. Unit test included. CCBUG: 257401 M +53 -0 tests/dolphindetailsviewtest.cpp M +3 -0 views/dolphindetailsview.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1199123 SVN commit 1199124 by freininghaus: Make sure that an item's visualRect in the Details View is not wider than the "Name" column. Fixes keyboard navigation problems if files with very wide names are present in the current folder. Unit test included. BUG: 257401 FIXED-IN: 4.5.4 M +3 -0 dolphindetailsview.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1199124 |