Bug 257007

Summary: memory leaks in attachedpictureframe.cpp
Product: [Frameworks and Libraries] taglib Reporter: Martin Tofall <support>
Component: generalAssignee: Scott Wheeler <wheeler>
Status: RESOLVED FIXED    
Severity: normal CC: lalinsky
Priority: NOR    
Version: 1.6.3   
Target Milestone: ---   
Platform: unspecified   
OS: All   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Martin Tofall 2010-11-15 19:16:52 UTC
Version:           1.6.3
OS:                All

The constructor
AttachedPictureFrameV22::AttachedPictureFrameV22(const ByteVector &data, Header *h)
allocates a new object
d = new AttachedPictureFramePrivate;
overwriting the previosuly allocated one (by AttachedPictureFrame::AttachedPictureFrame() : Frame("APIC"))
thus leaking memory. It then goes on to call
setHeader(newHeader, false);
which does not deallocate the previously set header, leaking memory again.

Reproducible: Always
Comment 1 Lukáš Lalinský 2011-01-08 12:16:00 UTC
SVN commit 1212871 by lalinsky:

Fix memory leak in AttachedPictureFrameV22

BUG:257007


 M  +1 -3      attachedpictureframe.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1212871