Bug 256802

Summary:	Improve Datepicker widget
Product:	[Unmaintained] KDE PIM Mobile	Reporter:	Björn Balazs <kde>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	VERIFIED FIXED
Severity:	normal	CC:	aheinecke
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Unlisted Binaries
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Björn Balazs 2010-11-13 15:25:34 UTC

Version:           unspecified (using Devel) 
OS:                Linux

There are some improvements possible in the datepicker widget, that it e.g. launched when selecting the date in Korganizer mobile:

Interacting directly with the calender is much more intuitive than opening a slider, sliding through a list and then closing it again. Therefore we should

- only allow to select the day by clicking on it on the calender.
- only allow to select the month by flicking the calender left and right. The Month should always be persented as "Nov" or "November" not as "11" to avoid cultural confusion.
- allow to change the year by flicking the calender up and down and by clicking on a drop-down-list (as we have)
- Always explicitely state the currently seleted date

13. Nov 2010 N900

Reproducible: Didn't try

Comment 1 Tobias Koenig 2011-01-13 11:09:43 UTC

commit 4c64269db7b3a94cb61c012d1b156cac75fe8498
branch master
Author: Tobias Koenig <tokoe@kde.org>
Date:   Thu Jan 13 11:12:13 2011 +0100

    Show month names in the month selector
    
    BUG: 256802

diff --git a/mobile/lib/VerticalSelector.qml b/mobile/lib/VerticalSelector.qml
index e7cb63e..34b4b19 100644
--- a/mobile/lib/VerticalSelector.qml
+++ b/mobile/lib/VerticalSelector.qml
@@ -30,6 +30,7 @@ Item {
     signal selected()
 
     property int beginWith: 0
+    property variant displayTexts
 
     onValueChanged: {
         list.positionViewAtIndex( value - beginWith, ListView.Center );
@@ -100,7 +101,7 @@ Item {
             width: verticalselector.width
             height: verticalselector.height
             Text {
-                text: list.currentIndex + beginWith
+                text: displayTexts ? displayTexts[list.currentIndex + beginWith] : list.currentIndex + beginWith
                 anchors.fill: parent
                 color: "#004bb8"
                 font.bold: true
diff --git a/mobile/lib/calendar/CalendarDialog.qml b/mobile/lib/calendar/CalendarDialog.qml
index feed684..815d843 100644
--- a/mobile/lib/calendar/CalendarDialog.qml
+++ b/mobile/lib/calendar/CalendarDialog.qml
@@ -107,6 +107,20 @@ Dialog {
             model: 12
             beginWith: 1
 
+            displayTexts : [ "dummy",
+                             KDE.i18n( "Jan" ),
+                             KDE.i18n( "Feb" ),
+                             KDE.i18n( "Mar" ),
+                             KDE.i18n( "Apr" ),
+                             KDE.i18n( "May" ),
+                             KDE.i18n( "Jun" ),
+                             KDE.i18n( "Jul" ),
+                             KDE.i18n( "Aug" ),
+                             KDE.i18n( "Sep" ),
+                             KDE.i18n( "Oct" ),
+                             KDE.i18n( "Nov" ),
+                             KDE.i18n( "Dec" ) ];
+
             onValueChanged: {
               // selector change -> update calendar
               myCalendar.month = value;

Comment 2 Andre Heinecke 2011-02-15 18:27:46 UTC

Datepicker is now much more usable. There is still room for usabilty improvements of course but the main problem of this bug has been fixed.