Bug 256758

Summary:	Visualizing pbs when opening an attachment from Message Viewer
Product:	[Unmaintained] KMail Mobile	Reporter:	Sabine Faure <sabine>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	CLOSED FIXED
Severity:	normal	CC:	bjoern.ricks, ludwig.reiter
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	First screenshot Second screenshot Third screenshot Fourth screenshot

Description Sabine Faure 2010-11-13 01:27:49 UTC

Version:           unspecified (using Devel) 
OS:                Linux

When the attachment is an image it is not properly displayed in the attachment tab.

Reproducible: Always

Steps to Reproduce:
Prerequisite: Send an email with a small image attached from a desktop computer to your Imap account on the N900 (ex: Email 1)

- Launch Kmail-mobile
- Click on your Imap inbox
- Click on Email 1
- Open the 'Attachment' tab
- The tab opens with the name of the file over the grey backgroup of the tab (see first screenshot)
- Click on the file name in the attachment tab

Actual Results:  
The file is partly displayed and in transparency over the email text since the attachment tab did not automatically open to fit the file size (see second screenshot). 

The user has to manually slide open the attachment tab until the image is fully displayed (see third screenshot) and it seems that when she does that the tab is not linked to the left hand side anymore.


Expected Results:  
The attachment should be displayed properly and adjust automatically to the file size when displayed, at least in width.

The attachment tab should stay linked to the left hand side like any over tab overwise it makes scrolling up and down the image very complicated.

Moreover if the user manages to close the image and then reopens it the image in the tab is opened from the middle of the N900 screen and not linked at all to the left hand side like the 'Actions' tab (see fourth screenshot).

N900, 4:4.6~20101112.1195992-1maemo1.1196001

Comment 1 Sabine Faure 2010-11-13 01:30:39 UTC

Created attachment 53375 [details]
First screenshot

N900, 4:4.6~20101112.1195992-1maemo1.1196001

Comment 2 Sabine Faure 2010-11-13 01:32:38 UTC

Created attachment 53376 [details]
Second screenshot

Comment 3 Sabine Faure 2010-11-13 01:35:53 UTC

Created attachment 53377 [details]
Third screenshot

Comment 4 Sabine Faure 2010-11-13 01:40:08 UTC

Created attachment 53378 [details]
Fourth screenshot

N900, 4:4.6~20101112.1195992-1maemo1.1196001

Comment 5 Sabine Faure 2010-11-13 01:43:27 UTC

Note: it would be a good idea to have the back to Message list icon (bottom right side) always visible even if the attachment tab is displayed over the entire N900 screen otherwise the user cannot go back to the Message List.

N900, 4:4.6~20101112.1195992-1maemo1.1196001

Comment 6 Artur Souza (MoRpHeUz) 2010-11-30 22:40:19 UTC

*** Bug 250633 has been marked as a duplicate of this bug. ***

Comment 7 Artur Souza (MoRpHeUz) 2010-12-01 00:10:11 UTC

SVN commit 1202459 by asouza:

AttachmentList needs a proper size when previewing images

In one of the states we had this comment:

"limited by SlideoutPanel to maximum width anyway"

that right now is not entirely true (SlideoutPanel does not limit the size).

The effect of this was that the requested width of '1000' was
being used and made the panel bigger than needed.

There is still the issue of not expanding the panel properly that
will be fixed in another commit.

Please note that flicking the image does not work horizontally
due to SlideoutPanel's nature of also being flickable in this
direction. The only way of solving this would be to do something
along the lines of calendar/time widgets where we have a dialog
and disable the drag capability of the panel.

CCBUG: 256758


 M  +2 -1      lib/AttachmentList.qml  
 M  +8 -1      mail/kmail-mobile.qml  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1202459

Comment 8 Artur Souza (MoRpHeUz) 2010-12-01 01:31:55 UTC

SVN commit 1202469 by asouza:

Use the whole screen while displaying attachments

The 'Flap' widget does not properly support changing on demand the
width of it's content. Because of this, it was very hard to make it
grow after the selection of a model without modifying the 'Flap' code.

To avoid regressions, I'm postponing the fix of the 'Flap' (that is used
in too many places to be changed now - for komo3) and using the default
width to display the attachments. This solves the issue of not properly
displaying the attachments, besides not being the most beautiful way of
doing it.

Before closing this bug, we'll do some polishing on the UI.

CCBUG: 256758


 M  +0 -4      lib/AttachmentList.qml  
 M  +0 -8      mail/kmail-mobile.qml  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1202469

Comment 9 Artur Souza (MoRpHeUz) 2010-12-01 19:11:34 UTC

SVN commit 1202648 by asouza:

A little polish on Attachment's UI

Just some little tweaks to improve the experience of openning attachments.
This should close the bug and later we can improve the Flaps to achieve
the original effect.

BUG:256758


 M  +2 -2      AttachmentList.qml  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1202648

Comment 10 Ludwig Reiter 2010-12-02 13:04:22 UTC

version: 20101202-1202744-1maemo1

The test png is displayed correctly.