Bug 256751

Summary:	'Previous' and 'Next' buttons do not work properly in Find in Message
Product:	[Unmaintained] KMail Mobile	Reporter:	Sabine Faure <sabine>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED UNMAINTAINED
Severity:	normal	CC:	tokoe
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Unlisted Binaries
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	pop up find dialogue much to small to be used

Description Sabine Faure 2010-11-13 00:30:38 UTC

Version:           unspecified
OS:                Linux

When doing a search within an email the 'Previous' and 'Next' buttons do not work as they should.

Reproducible: Always

Steps to Reproduce:
- Launch Kmail-mobile
- Click on your Imap inbox
- Click on an email that contains a signature at the end (ex: KDAB std signature or several times AB and ab in subject and body)
- Open the 'Actions' tab
- Click on 'Email'
- Click on 'Find in Message'
- Type capital letters included in the email signature in the 'Find:' line edit(ex: AB)
- Click on 'Options' button and select 'Case sensitive'
- Press 'Enter' from the N900 keyboard
- One occurence of AB is found and at the same time the 'Next' and 'Previous' buttons have become available.
- Click on the 'Next' button several times and you will see that once the bottom of the email is reached the search is automatically started again from the top of the email
- Click on the 'Previous' button


Actual Results:  
Once the top of the email is reached both buttons are not available anymore.

Atm the only way to activate them again is to click on 'Enter' from the N900 keyboard

Expected Results:  
Once the top of the email is reached the search should go back to the bottom like it is the case with the 'Next' button.

A difference in behaviour between the 'Next' and the 'Previous' button is confusing imho.

I retested this without the upper case and still the 'Next' and 'Previous' buttons are not behaving properly: they miss some entries or stop working altogether.

Also the 'Enter' key find all the entries (upper and lower cases) but they are displayed in a weird order: top right of the N900 screen, then bottom right, then top left and finally bottom left.

N900, 4:4.6~20101112.1195992-1maemo1.1196001

Comment 1 Tobias Koenig 2010-12-10 10:47:42 UTC

SVN commit 1205170 by tokoe:

Do not overwrite the FindWrapsAroundDocument flag in
'search backwards' mode.

BUG: 256751


 M  +1 -1      findbar.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1205170

Comment 2 Sabine Faure 2010-12-10 18:54:44 UTC

I retested this today and the main bug is still reproductible:

The 2 buttons (previous and next) are not available anymore once the top of the email is reached using 'Previous' button.

This bug is reproductible both with and without the upper case option.

(To reproduce send an email to toto@kdab.com called 'Test 1 KDAB' and type 'KDAB, kdab, KDAB, kdab, KDAB, kdab')


Bugs specific to case with more details after retesting:

- With the upper case option the 'Enter' key works fine and find all the correct items. Each time the user presses enter the next search item is highlighted as it should.
To reproduce -> type: 'AB' in the 'Find:' field and select upper case option

- Without the upper case option the 'Enter' key moves to another searched item but skips the next two items that should be found to only highlight the third one every time the user presses 'Enter'.
To reproduce -> Clear the previous search if still displayed, remove the upper case option and type:'ab' in the 'Find:' field 

For all this reasons I am reopening this bug.

N900, 4:4.6~20101210.1205130-1maemo1.1204898

Comment 3 Sabine Faure 2010-12-10 20:49:15 UTC

In comment #2 to reproduce the bugs described I meant activate the 'case sensitive' option and deactivate it instead of the 'upper case' one that does not exist.

I could not read the option's name properly because of bug #259461 hence the mix up. Sorry about that

N900, 4:4.6~20101210.1205130-1maemo1.1204898

Comment 4 Tobias Koenig 2010-12-21 14:35:48 UTC

SVN commit 1208391 by tokoe:

Do not disable buttons when end/beginning of message is reached.

With the underlying search design, we can't enable/disable the buttons properly,
so don't use this mechanism at all but show a messagebox if the end or beginning
of the message has been reached and no result has been found.

BUG: 256751


 M  +14 -7     findbar.cpp  
 M  +1 -1      findbar.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1208391

Comment 5 Sabine Faure 2010-12-22 22:49:04 UTC

Cannot retest because of bug #261010 - Search pop up dialogue too small (Regression)

Will retest as soon as that bug is fixed.

N900, 4:4.6~20101222.1208531-1maemo1.1208558

Comment 6 Sabine Faure 2011-01-08 01:10:29 UTC

Created attachment 55718 [details]
pop up find dialogue much to small to be used

I retested this bug today and the pop up 'Find' dialogue is so small that it is impossible to use (see attachment enclosed) so I am reopening this bug.

N900, 4:4.6~.20110106.1209.gitfde48d5-1maemo1.121147

Comment 7 Tobias Koenig 2011-01-12 16:16:19 UTC

Hej Sabine,

this seems to be a Qt-on-Maemo bug, on my N900 for example the buttons are always fully visible. Since WinCE doesn't has this problem, I'll remove the komo3 tag.

Ciao,
Tobias