Bug 256436

Summary: Amarok resizes/moves when trying to select multiple entries in Media Sources with mouse.
Product: [Applications] amarok Reporter: vatoslocos <gtsangaris>
Component: generalAssignee: Amarok Developers <amarok-bugs-dist>
Status: RESOLVED FIXED    
Severity: normal CC: bart.cerneels, hugo.pereira.da.costa, lfranchi, stuffcorpse
Priority: NOR    
Version: 2.3.2   
Target Milestone: 2.4.0   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed In: 2.4
Sentry Crash Report:

Description vatoslocos 2010-11-09 13:11:51 UTC
Version:           2.3.2 (using KDE 4.5.3) 
OS:                Linux

If you click in Media Sources (if there is empty space after the last entry) and drag the mouse to select multiple files Amarok automatically resizes (if it is fullscreen). If it's not fullscreen, it moves.

Reproducible: Always

Steps to Reproduce:
Go to Media Sources View.
Point mouse after last entry.
Press left click and move mouse.

Actual Results:  
If amarok is in fullscreen mode it resized (like when pressing the restore button).
If it isn't in fullscreen, the window moves.

Expected Results:  
If you browse local files, select multiple files.
If you are at the initial media sources screen, do nothing.

OS: Linux (i686) release 2.6.35-22-generic
Compiler: cc
Comment 1 Rick W. Chen 2010-11-09 14:02:54 UTC
It sounds like the kwin feature where if you drag on some place that has no interaction it will move the window. In that case it's not really amarok's issue, although it'd probably help if we can disable the behaviour when inside the collection browser.
Comment 2 vatoslocos 2010-11-09 14:22:39 UTC
If it's kwin's feature, i think it should be disabled.

It's really annoying and somehow affects the "Media Sources"'s properties.
After the bug has been produced, when "Media Sources" resizes when browsing through local files, you cannot resize it back to it's initial width.

See bug 256439 (https://bugs.kde.org/show_bug.cgi?id=256439)
Comment 3 Myriam Schweingruber 2010-11-09 15:14:51 UTC
(In reply to comment #2)
> If it's kwin's feature, i think it should be disabled.
> 
> It's really annoying and somehow affects the "Media Sources"'s properties.
> After the bug has been produced, when "Media Sources" resizes when browsing
> through local files, you cannot resize it back to it's initial width.
> 
> See bug 256439 (https://bugs.kde.org/show_bug.cgi?id=256439)

Which is not related IMHO
Comment 4 Bart Cerneels 2010-11-09 17:07:56 UTC
There is a new feature in oxygen, empty areas of the window can be used as a drag handle: https://bugs.kde.org/show_bug.cgi?id=241415
However, for some reason it mistakenly thinks the browser area's below the items are empty. We're investigating it.
Comment 5 Bart Cerneels 2010-11-09 17:08:06 UTC
There is a new feature in oxygen, empty areas of the window can be used as a drag handle: https://bugs.kde.org/show_bug.cgi?id=241415
However, for some reason it mistakenly thinks the browser area's below the items are empty. We're investigating it.
Comment 6 Hugo Pereira Da Costa 2010-11-09 17:17:41 UTC
So. Indeed the 'drag window from empty area' is a feature from oxygen (and a couple of other well-known kde4 styles). For oxygen you can disable it by typing 'oxygen-settings' in terminal (or krunner), and change the option named "windows' drag mode" to whatever suits you best.

In the meanwhile I'll work with bart to see if we can restore the media sources capabilities without the need of disable the oxygen feature.
Comment 7 Hugo Pereira Da Costa 2010-11-10 10:55:44 UTC
@ first comment:
what exactly is "Media Sources". Can you send a screenshot ? So far I have not been enabled to reproduce the problem (which makes it hard to fix), most likely because I am not looking at the right place.

Thanks 

Hugo
Comment 8 Bart Cerneels 2010-11-10 12:24:31 UTC
In a default setup it's the panel on the left. Menu > view > Lock Layout unchecked will show the title of the panel.

In the root of this view window dragging is no problem, but in all the other browser, which show files, tracks, albums, etc; the rubberband selection method is broken.

Bart
Comment 9 Hugo Pereira Da Costa 2010-11-10 12:35:06 UTC
Thx. Yes indeed it does not work well when browsing e.g. file system. 
Interestingly, it does work well in the right panel though. Right ? 
I'll be investigating.
Comment 10 Bart Cerneels 2010-11-10 12:45:16 UTC
(In reply to comment #9)
> Thx. Yes indeed it does not work well when browsing e.g. file system. 
> Interestingly, it does work well in the right panel though. Right ? 
> I'll be investigating.

Yes, in the playlist it works. It's completely different from the browsers though (Media sources classes are named like that).
Comment 11 Hugo Pereira Da Costa 2010-11-10 14:29:24 UTC
SVN commit 1195136 by hpereiradacosta:

Prevent dragging from treeviews' viewport empty area when multiple selection is allowed.
CCBUG: 256436


 M  +3 -1      oxygenwindowmanager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1195136
Comment 12 Hugo Pereira Da Costa 2010-11-10 14:31:05 UTC
SVN commit 1195137 by hpereiradacosta:

Backport r1195136
Prevent dragging from treeviews' viewport empty area when multiple selection is
allowed.

CCBUG: 256436


 M  +3 -1      oxygenwindowmanager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1195137
Comment 13 Hugo Pereira Da Costa 2010-11-10 14:31:54 UTC
I 'think' commits from comments #11 and #12 (backport to kde4.5 branch) fixes it. Please confirm and close the bug if yes.
Comment 14 Hugo Pereira Da Costa 2010-11-10 14:33:13 UTC
PS: these are commits to oxygen. Not amarok.
Also, at the moment I am unable to copile amarok from trunk (due to a problem of my distrib with mysqld and libmysql-dev). So I only tested against amarok v2.3.1
Comment 15 Leo Franchi 2010-11-11 20:39:02 UTC
Thanks Hugo, that fixed it!