Bug 256322

On Sunday 07 November 2010 19:06:14 Jan Hofmann wrote:
> https://bugs.kde.org/show_bug.cgi?id=256322
> 
>            Summary: rekonq does not show anything from the history in the
>                     url bar
>            Product: rekonq
>            Version: 0.6.1
>           Platform: Gentoo Packages
>         OS/Version: Linux
>             Status: NEW
>           Severity: normal
>           Priority: NOR
>          Component: general
>         AssignedTo: adjam7@gmail.com
>         ReportedBy: elusive@virtualpixel.de
> 
> 
> Version:           0.6.1 (using KDE 4.5.2)
> OS:                Linux
> 
> I checked it with both versions, git and 0.6.1:
> 
> If I start typing something into the url bar which IS in the browser
> history, the url bar does not show it.
> All other things are working fine in the url bar, like bookmarks and google
> suggestions.
> 
> I checked it with an other fresh test-user, but i got the same problem. On
> my Laptop, which runs kubuntu 10.10 the history is working inside the url
> bar. So it seems to be some gentoo specific problem perhabs?
> 
> What ca I provide to resolve the problem? Which logfiles or traces?
> 
> Without history-search inside the url bar, rekonq is pretty useless for me
> :(
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> Visit a site, close the browser, re-open it and type the just visited site
> into the url bar.
> 
> Actual Results:
> The url bar doe not complete your typing and doesn't show you anything from
> the history.
> 
> Expected Results:
> The url bar shout give me some suggestions from my browser-history and/or
> should autocompete my typing.

Uhm.. try checking first your "web-shortcuts" setting. Compare (gentoo vs 
kubuntu) the default search engine setting.

(In reply to comment #1)
> Uhm.. try checking first your "web-shortcuts" setting. Compare (gentoo vs 
> kubuntu) the default search engine setting.

Well, that does the trick, thx! On my Gentoo installation, the default search provider was "none". I switched it to google et voila, history serch is working!

But that seems to be a bug too :) Google search was working great, although the search provider was none. And why is the history search depending on google (or whatever searchprovider you choose?

On Monday 08 November 2010 07:40:07 Jan Hofmann wrote:
> https://bugs.kde.org/show_bug.cgi?id=256322
> 
> 
> 
> 
> 
> --- Comment #2 from Jan Hofmann <elusive virtualpixel de>  2010-11-08
> 07:40:05 --- (In reply to comment #1)
> 
> > Uhm.. try checking first your "web-shortcuts" setting. Compare (gentoo vs
> > kubuntu) the default search engine setting.
> 
> Well, that does the trick, thx! On my Gentoo installation, the default
> search provider was "none". I switched it to google et voila, history
> serch is working!
> 
> But that seems to be a bug too :) Google search was working great, although
> the search provider was none. And why is the history search depending on
> google (or whatever searchprovider you choose?

Uhm.. yes (it seems a bug)! In fact I was waiting your reply to take a look at 
the code ;)

Regards,

Had the same problem here and it could be resolved by setting a default search. This should be fixed ;)

hi, I faced with that problem yesterday, hope patch could help

diff --git a/src/urlbar/urlresolver.cpp b/src/urlbar/urlresolver.cpp
index d89f27d..ffadd7e 100644
--- a/src/urlbar/urlresolver.cpp
+++ b/src/urlbar/urlresolver.cpp
@@ -112,6 +112,11 @@ UrlResolver::UrlResolver(const QString &typedUrl)
             else
                 reg = reg + "|(" + engineUrl + ')';
         }
+        if(reg.isEmpty()) {
+            qDebug() << "Default search engine is not selected";
+            reg = "(http://www\\.google\\.com/search\\?q=[\\d\\w-.]+&ie=UTF-8&oe=UTF-8)";
+            // cutted from reg, but it is wrong my search query looks like google.ru/search?hl=ru&q=..
+        }
         _searchEnginesRegexp = QRegExp(reg);
     }
 }

Still reproducible on 0.8.1, here.

Changing default search engine didn't help.

Sorry, I really cannot reproduce your bug with any settings tried (no default search engine, google search engine, amazon search engine, etc...).
History entries (when available) are always shown here.

searchengine.cpp, line 61: the call to cg.readEntry() fails, returning a string list containing "cannot access memory at address 0xd", one character per string.

This way, Favourites list remains empty, QString reg, declared at urlresolver.cpp:105 isn't properly filled, _searchEnginesRegexp will be constructed as a QRegExp on an empty string, the call to _searchEnginesRegexp.indexIn(), urlresolver.cpp:343 never returns -1, every history entry is cut away.

I'd replace ulresolver.cpp:344 with
if (_searchEnginesRegexp.isEmpty() || _searchEnginesRegexp.indexIn(i.url) == -1)

Git commit 0791fdb4347b59e486a3be2e4a0514ac661e76dd by Andrea Diamantini.
Committed on 15/12/2011 at 17:09.
Pushed by adjam into branch 'master'.

show history entries also when no favorite search engine is set

Bug investigation and courtesy patch by Gabo Menna.
Many thanks for :D

BUG: 256322

M  +1    -1    src/urlbar/urlresolver.cpp

http://commits.kde.org/rekonq/0791fdb4347b59e486a3be2e4a0514ac661e76dd

Git commit b34b4af8ec0b7f4508bfdecc1018aa02b905ac4a by Andrea Diamantini.
Committed on 15/12/2011 at 17:09.
Pushed by adjam into branch 'Branches.0.8'.

show history entries also when no favorite search engine is set

Bug investigation and courtesy patch by Gabo Menna.
Many thanks for :D

BUG: 256322

M  +1    -1    src/urlbar/urlresolver.cpp

http://commits.kde.org/rekonq/b34b4af8ec0b7f4508bfdecc1018aa02b905ac4a

*** Bug 274757 has been marked as a duplicate of this bug. ***