Bug 256194

Summary:	No 'Mark as no longer important' button
Product:	[Applications] KMail Mobile	Reporter:	Sabine Faure <sabine>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	CLOSED DUPLICATE
Severity:	normal	CC:	adam, ludwig.reiter
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:

Description Sabine Faure 2010-11-05 23:28:57 UTC

Version:           unspecified (using Devel) 
OS:                Linux

Once the user has set an email as important if he wants to remove that setting he has to click on the 'Mark as Important' again which does not seem logical.

Reproducible: Always

Steps to Reproduce:
- Launch Kmail-mobile
- Click on your Imap inbox
- Click on an email to display its content
- Open the 'Actions' tab
- Click on 'Email'
- Click on 'Mark As...'
- Click on 'Mark as Important' button
- Click on the small icon at the bottom right to go back to the message viewer
- There is now an exclamation point transparent icon over the email subject you selected to show that it is marked as important
- Click on the email again
- Open the 'Actions' tab
- Click on 'Email'
- Click on 'Mark As...'

Actual Results:  
The user has to reclick on 'Mark as Important' to remove the Mark as important exclamation point from the email subject in the Message viewer.

Expected Results:  
This does not seem logical.

It would be better to have another button called 'Mark as no longer important' or to change the 'Mark as Important' button label depending if the option is on or off.

The same bug can be found with the 'Mark as Action Item' button since there is no 'Mark as no longer an Action Item' button.

N900, 4:4.6~20101105.1193208-1maemo1.1193066

Comment 1 Till Adam 2010-11-07 20:29:20 UTC

SVN commit 1193973 by tilladam:

Use the action's text for important and todo status setting.

By using the action's text, instead of setting one ourselves, we get the
text for the unset-in-case-it's-already-set correctly for free. Seems
more correct not to duplicate the string anyhow.

BUG: 256194

 M  +2 -2      kmail-mobile.qml  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1193973

Comment 2 Ludwig Reiter 2010-11-08 14:42:20 UTC

tested with snapshot 20101108.1194089

"Remove Important Mark" is displayed at the second look at E-Mails.

But follwoing test failed:
1. Select a mail.
2. Mark mail as important.
3. Stay in the mail view and try to mark as not important.
=> It seems like Kmail didn't recognized, that I have marked the mail as important.

Comment 3 Till Adam 2010-11-11 22:02:08 UTC


*** This bug has been marked as a duplicate of bug 256198 ***

Comment 4 Sabine Faure 2010-11-12 20:34:30 UTC

It is corrected now.

Once an email as been marked as important its button label changes from 'Mark Mail as Important' to 'Remove Important Mark'.

I also tested setting and unsetting an email as important without leaving the Message viewer (see comment #2 for description) and it worked fine for me.

All of this also works for marking or unmarking an email as an action item.

So I am closing this bug. Ludwig, feel free to reopen if it does not work for you.

N900, 4:4.6~20101112.1195992-1maemo1.1196001