Bug 255998

Summary:	Provide visual indication of a page being saved
Product:	[Unmaintained] kjots	Reporter:	Anders Lund <anderslund>
Component:	general	Assignee:	Stephen Kelly <steveire>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	0.4
Target Milestone:	---
Platform:	Unlisted Binaries
OS:	Linux
Latest Commit:	https://commits.kde.org/kjots/ad0f09f7986b141da58f5f8748d40daf448ba4d2	Version Fixed In:
Sentry Crash Report:

Description Anders Lund 2010-11-03 22:36:52 UTC

Version:           0.4
OS:                Linux

I had a very bad incident of data loss today. I rebooted my system using KDM, and when it came back i had lost a lot of notes from my kjots bookshelf, everything since last reboot it seems, looking at the files in .kde4/share/apps/kjots.
 
The loss is probably not a programming error in kjots, i suspect it happened because of a crash in kontact.

But i think kjots should do more autosaving, either everytime a document is changed, or in intervals. Alternatively, PLEASE provide a save menu item. I can see that there is a save action, it is just not in the menu, at least when kjots is embedded in kontact. Please put it there, even in addition to autosave improvements.

Apart from data loss, kjots is fine. But data loss is not acceptable, even if it is not directly kjots' fault!! 

Reproducible: Didn't try




OS: Linux (i686) release 2.6.35-ARCH
Compiler: gcc

Comment 1 Anders Lund 2010-11-04 09:13:34 UTC

Afterthought: If your progam have documents with unsaved data, this should be visible in the ui. There are standards for how to do that.

Comment 2 Stephen Kelly 2010-11-04 16:38:20 UTC

This is odd. KJots does save periodically. What version of KDEPIM is this? Trunk? 4.5? What is in .kde4/share/apps/kjots?

Comment 3 Anders Lund 2010-11-04 18:10:08 UTC

KDE 4.5.2
Kontact/kdepim 4.4.7

[anders@katja ~]$ ls -l .kde4/share/apps/kjots/
totalt 1520
-rw------- 1 anders anders 32742 04.11.2010 11:07 AK3645.book
-rw------- 1 anders anders 32742 04.11.2010 11:07 AK3645.book.1~
-rw------- 1 anders anders 21887 27.07.2010 21:13 AK3645.book.10~
-rw------- 1 anders anders 32742 04.11.2010 00:24 AK3645.book.2~
-rw------- 1 anders anders 32742 03.11.2010 17:07 AK3645.book.3~
-rw------- 1 anders anders 30329 02.11.2010 00:30 AK3645.book.4~
-rw------- 1 anders anders 30329 10.10.2010 00:31 AK3645.book.5~
-rw------- 1 anders anders 21887 06.09.2010 16:10 AK3645.book.6~
-rw------- 1 anders anders 21887 05.09.2010 23:14 AK3645.book.7~
-rw------- 1 anders anders 21887 25.08.2010 09:06 AK3645.book.8~
-rw------- 1 anders anders 21887 30.07.2010 00:42 AK3645.book.9~
-rw-r--r-- 1 anders anders   274 08.10.2010 10:34 bookmarks.xml
-rw-r--r-- 1 anders anders   274 08.10.2010 10:34 bookmarks.xml.bak
-rw-r--r-- 1 anders anders     0 08.10.2010 10:34 bookmarks.xml.tbcache
-rw-r--r-- 1 anders users   2982 07.02.2010 19:45 kjotsui.rc
-rw------- 1 anders anders 70116 04.11.2010 11:07 oB4479.book
-rw------- 1 anders anders 70116 04.11.2010 11:07 oB4479.book.1~
-rw------- 1 anders anders 46811 27.07.2010 21:13 oB4479.book.10~
-rw------- 1 anders anders 70116 04.11.2010 00:24 oB4479.book.2~
-rw------- 1 anders anders 70116 03.11.2010 17:07 oB4479.book.3~
-rw------- 1 anders anders 64534 02.11.2010 00:30 oB4479.book.4~
-rw------- 1 anders anders 64534 10.10.2010 00:31 oB4479.book.5~
-rw------- 1 anders anders 46811 06.09.2010 16:10 oB4479.book.6~
-rw------- 1 anders anders 46811 05.09.2010 23:14 oB4479.book.7~
-rw------- 1 anders anders 46811 25.08.2010 09:06 oB4479.book.8~
-rw------- 1 anders anders 46811 30.07.2010 00:42 oB4479.book.9~
-rw------- 1 anders anders  1225 04.11.2010 11:07 S10819.book
-rw------- 1 anders anders  1225 04.11.2010 11:07 S10819.book.1~
-rw------- 1 anders anders   971 27.07.2010 21:13 S10819.book.10~
-rw------- 1 anders anders  1225 04.11.2010 00:24 S10819.book.2~
-rw------- 1 anders anders  1225 03.11.2010 17:07 S10819.book.3~
-rw------- 1 anders anders  1169 02.11.2010 00:30 S10819.book.4~
-rw------- 1 anders anders  1169 10.10.2010 00:31 S10819.book.5~
-rw------- 1 anders anders   971 06.09.2010 16:10 S10819.book.6~
-rw------- 1 anders anders   971 05.09.2010 23:14 S10819.book.7~
-rw------- 1 anders anders   971 25.08.2010 09:06 S10819.book.8~
-rw------- 1 anders anders   971 30.07.2010 00:42 S10819.book.9~
-rw------- 1 anders anders  7287 04.11.2010 11:07 SX6052.book
-rw------- 1 anders anders  7287 04.11.2010 11:07 SX6052.book.1~
-rw------- 1 anders anders  7287 04.11.2010 00:24 SX6052.book.2~
-rw------- 1 anders anders  7287 03.11.2010 17:07 SX6052.book.3~
-rw------- 1 anders anders  6890 02.11.2010 00:30 SX6052.book.4~
-rw------- 1 anders anders  6890 10.10.2010 00:31 SX6052.book.5~
-rw------- 1 anders anders  5152 06.09.2010 16:10 SX6052.book.6~
-rw------- 1 anders anders  5152 05.09.2010 23:14 SX6052.book.7~
-rw------- 1 anders anders 90977 04.11.2010 11:07 t13895.book
-rw------- 1 anders anders 87506 04.11.2010 11:07 t13895.book.1~
-rw------- 1 anders anders 87506 04.11.2010 00:24 t13895.book.2~
-rw------- 1 anders anders 86008 03.11.2010 17:07 t13895.book.3~
-rw------- 1 anders anders 80229 02.11.2010 00:30 t13895.book.4~

I opened that directory with dolphin to search for a backup that could contain the lost text, but didn't find any, based on dates (and did not find any)

Comment 4 Anders Lund 2010-11-09 09:15:19 UTC

I have had another incident of an unsaved page!!!

I think it is the current page. I have nested books, eg school->history->pagename.

Comment 5 Igor Poboiko 2020-05-05 09:06:30 UTC

Git commit e520aa4b49a50da8d2b1f08e4b8676213baa5cde by Igor Poboiko.
Committed on 05/05/2020 at 09:06.
Pushed by poboiko into branch 'master'.

[KJots] Provide explicit "Save" action, use standard actions where possible

Summary:
Use some standard actions for save, next page, previous page, rename.
Add "Save" action to menu and toolbar, otherwise it's not even clear how to save the note.
Don't use `QInputDialog` when renaming, just trigger inline rename.

Also, perform save procedure on quit (inside `KJotsWidget::queryClose`).
TODO: this is not yet functional, need to perform a synchronous job and wait for result.
Related: bug 296242

Test Plan: All actions are functional

Reviewers: dvratil

Reviewed By: dvratil

Subscribers: kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D29291

M  +1    -1    src/KJotsMain.cpp
M  +5    -4    src/kjotspartui.rc
M  +3    -39   src/kjotstreeview.cpp
M  +3    -1    src/kjotstreeview.h
M  +6    -4    src/kjotsui.rc
M  +10   -21   src/kjotswidget.cpp

https://commits.kde.org/kjots/e520aa4b49a50da8d2b1f08e4b8676213baa5cde

Comment 6 Igor Poboiko 2020-05-12 11:02:00 UTC

Git commit ad0f09f7986b141da58f5f8748d40daf448ba4d2 by Igor Poboiko.
Committed on 12/05/2020 at 10:58.
Pushed by poboiko into branch 'master'.

Provide visual indication whether the document is changed

(via the asterisk in a window title).

M  +13   -4    src/kjotsedit.cpp
M  +5    -0    src/kjotsedit.h
M  +1    -1    src/kjotsmodel.cpp
M  +5    -1    src/kjotswidget.cpp

https://commits.kde.org/kjots/ad0f09f7986b141da58f5f8748d40daf448ba4d2