Bug 255730

Summary: KGet bug when downloading finished
Product: [Applications] kget Reporter: Aaron Lewis <the.warl0ck.1989>
Component: generalAssignee: KGet bugs <kget-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Aaron Lewis 2010-10-31 11:01:11 UTC 
Version:           unspecified (using KDE 4.5.2) 
OS:                Linux

when downloading finished , a plasma ballon popup with a button mounted on that dialog ( open location ) , and if i click on it , it would tell me:

File doesn't exist , "file://DOWNLOAD_DIR/to different location" , 
obviously putting wrong argument in it.

It shouldn't end up with the description "to different location" , should be file name

Reproducible: Always
Comment 1 Lukas Appelhans 2010-10-31 12:52:16 UTC 
Are you sure this notification is from KGet as it seems kget never puts such a button on it...

Does it have the KGet icon?

Lukas
Comment 2 Aaron Lewis 2010-10-31 13:34:33 UTC 
Sure it has kget's default icon.

Firstly add a new downloading , then progress bar popup as plasma notifications

Source: KGet is downloading X files
Destination: to different locations ( Oh , that's why this bug exists , wasn't it )

And when it's finished , a message popup , telling me transfer complete , and if i want to take a look at its destination , so i click on the button , and it tell me "file://DIR/to some different location" doesn't exist.

And the finial plasma ballon , Layout goes like this one

[KGet Icon] KGet global information [Completed]

{LINK} to different locations {/LINK} ( likes to be <a href .. > XX </a> ) 
  {PLACE HOLDERS ... }      { BUTTON } Open Location { /BUTTON }

(Likes to be QDesktopService::openURL fails to work properly as parameter is wrong)
Comment 3 Lukas Appelhans 2010-10-31 13:42:15 UTC 
Ahh I see it isn't the usual kget notifications, but the progress-tracking :)

Lukas
Comment 4 Aaron Lewis 2010-11-01 06:06:08 UTC 
So when it's fixed , post a patch here and let me try out ;-)

KGet 2.5.2 with kdelibs 4.5.2.
Comment 5 Lukas Appelhans 2010-11-08 14:19:00 UTC 
SVN commit 1194254 by lappelhans:

Don't show information which we don't have (in this case the destination)
BUG:255730


 M  +1 -2      kgetglobaljob.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1194254
Comment 6 Aaron Lewis 2010-11-08 14:39:07 UTC 
Great job.
Comment 7 Lukas Appelhans 2010-11-08 18:12:33 UTC 
SVN commit 1194316 by lappelhans:

Backport of SVN commit 1194254 by lappelhans:

Don't show information which we don't have (in this case the 
destination)
CCBUG:255730



 M  +1 -2      kgetglobaljob.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1194316