| Summary: | Collection scanner misses APETAGEX if Lyrics3 tag is present | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] taglib | Reporter: | Matt Whitlock <kde> |
| Component: | general | Assignee: | Lukáš Lalinský <lalinsky> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | normal | CC: | lalinsky, mitchell |
| Priority: | NOR | ||
| Version: | 1.6.3 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Find the APE tag even if there's a Lyrics3v2 present
Find the APE tag even if there's a Lyrics3v2 present; Version 2 |
||
For the tracks without these lyrics blocks, are the ReplayGain values read correctly? (You don't say.) Yes, all the tracks without a Lyrics3 block have their Replay Gain values read correctly from the APETAGEX blocks. I've verified that all of our tags for this are coming from TagLib -- so if the tag isn't being found, it's due to TagLib not finding it. Reassigning to TagLib so they can take a look. Created attachment 55453 [details]
Find the APE tag even if there's a Lyrics3v2 present
I ran into the same problem and wrote a patch - hopefully that's something to build on. It doesn't work with all files though.
Created attachment 55464 [details]
Find the APE tag even if there's a Lyrics3v2 present; Version 2
Ok, fixed a stupid mistake, now it's working with all of my files.
Dear Bug Submitter, This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond. Thank you for helping us make KDE software even better for everyone! Dear Bug Submitter, This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand. Thank you for helping us make KDE software even better for everyone! Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version? If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you! Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone! |
Version: 2.3.2 (using KDE 4.5.2) OS: Linux I had a few MP3 tracks in my collection that had valid ReplayGain tags ("aacgain -s c" showed the correct data), but Amarok wasn't importing the ReplayGain values into its database. I discovered that all of them had an extra block of tags between the ID3v1 tag and the APETAGEX block. The block begins with BEGINLYRICS and ends with LYRICS200. Apparently this block is a Lyrics3v2 tag: http://www.id3.org/Lyrics3v2 I don't care if Amarok does anything with the information in that (in fact I'd prefer that it didn't since Lyrics3 is evidently an abandoned standard), but the presence of a Lyrics3 block shouldn't prevent Amarok from reading the APETAGEX block and picking up the ReplayGain info. Perhaps Amarok could just detect the Lyrics3 block immediately preceding the ID3v1 block, read its size, and skip over it to find the APETAGEX. Reproducible: Always OS: Linux (x86_64) release 2.6.34-gentoo-r6 Compiler: x86_64-pc-linux-gnu-gcc