| Summary: | request for Hong Kong holidays | ||
|---|---|---|---|
| Product: | [Applications] kdepimlibs | Reporter: | Glen Ng <pariahsoc> |
| Component: | kholidays | Assignee: | John Layt <jlayt> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jlayt, miklcct |
| Priority: | NOR | ||
| Version: | 4.5 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 4.6.2 | |
| Sentry Crash Report: | |||
| Attachments: |
the holiday file I tried to write by myself
Holiday file for Hong Kong SAR(China) Holiday file for Hong Kong SAR(China) (ENGLISH) Holiday file for Hong Kong SAR(China) (CHINESE) Holiday file for Hong Kong SAR(China) (ENGLISH) Holiday file for Hong Kong SAR(China) (CHINESE) |
||
|
Description
Glen Ng
2010-10-13 16:32:13 UTC
How can I test the holiday file? I googled but there did not seem to be instructions. 1. I think that renaming the file to holiday_hk will be more appropriate because it will be displayed as "Hong Kong SAR(China)" I've modified it and attached a new modified version of the holiday file which is tested on my system (KDE 4.4.5) Created attachment 54862 [details]
Holiday file for Hong Kong SAR(China)
tested on KDE 4.4.5
Created attachment 55154 [details]
Holiday file for Hong Kong SAR(China) (ENGLISH)
Do you think that putting Ching Ming Festival onto the solar calendar section is more appropriate? It's nearly always on 5 April, with only occasional exceptions once in 4 years. Created attachment 55509 [details]
Holiday file for Hong Kong SAR(China) (CHINESE)
加入二十四節氣
Git commit f423c49b4b7b9ab21965ede9551cec0694686536 by John Layt. Committed on 25/02/2011 at 15:39. Pushed by jlayt into branch '4.6'. KHoliday: Add Hong Kong holiday files Add holiday files for Hong Kong in English and Chinese. Note these include holidays in the Chinese lunar calendar which I have provided fixed dates for in the period 2000-2010. CCBUG: 254073 A +206 -0 kholidays/holidays/plan2/holiday_hk_en-gb [License: UNKNOWN] * A +206 -0 kholidays/holidays/plan2/holiday_hk_zh-cn [License: UNKNOWN] * The files marked with a * at the end have a non valid license. Please read: http://techbase.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page. http://commits.kde.org/kdepimlibs/f423c49b4b7b9ab21965ede9551cec0694686536 Git commit 4454ec0fd2901861b9e7f1283321e16a69d3d50b by John Layt. Committed on 25/02/2011 at 15:39. Pushed by jlayt into branch 'master'. KHoliday: Add Hong Kong holiday files Add holiday files for Hong Kong in English and Chinese. Note these include holidays in the Chinese lunar calendar which I have provided fixed dates for in the period 2000-2010. BUG: 254073 FIXED-IN: 4.6.2 FORWARD-PORT: f423c49b4b7b9ab21965ede9551cec0694686536 A +206 -0 kholidays/holidays/plan2/holiday_hk_en-gb [License: UNKNOWN] * A +206 -0 kholidays/holidays/plan2/holiday_hk_zh-cn [License: UNKNOWN] * The files marked with a * at the end have a non valid license. Please read: http://techbase.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page. http://commits.kde.org/kdepimlibs/4454ec0fd2901861b9e7f1283321e16a69d3d50b On Saturday 26 February 2011 07:45:37 John Layt wrote:
> https://bugs.kde.org/show_bug.cgi?id=254073
>
>
> John Layt <john@layt.net> changed:
>
> What |Removed |Added
> ---------------------------------------------------------------------------
> - Status|ASSIGNED |RESOLVED
> Version Fixed In| |4.6.2
> Resolution| |FIXED
>
>
>
>
> --- Comment #8 from John Layt <john layt net> 2011-02-26 00:45:36 ---
> Git commit 4454ec0fd2901861b9e7f1283321e16a69d3d50b by John Layt.
> Committed on 25/02/2011 at 15:39.
> Pushed by jlayt into branch 'master'.
>
> KHoliday: Add Hong Kong holiday files
>
> Add holiday files for Hong Kong in English and Chinese. Note these
> include holidays in the Chinese lunar calendar which I have provided
> fixed dates for in the period 2000-2010.
>
> BUG: 254073
> FIXED-IN: 4.6.2
>
> FORWARD-PORT: f423c49b4b7b9ab21965ede9551cec0694686536
>
> A +206 -0 kholidays/holidays/plan2/holiday_hk_en-gb [License:
> UNKNOWN] *
> A +206 -0 kholidays/holidays/plan2/holiday_hk_zh-cn [License:
> UNKNOWN] *
>
> The files marked with a * at the end have a non valid license. Please read:
> http://techbase.kde.org/Policies/Licensing_Policy and use the headers which
> are listed at that page.
>
>
> http://commits.kde.org/kdepimlibs/4454ec0fd2901861b9e7f1283321e16a69d3d50b
It doesn't work on my KDE 4.4. Does it work on later versions?
On Saturday 26 February 2011 07:45:37 John Layt wrote:
> https://bugs.kde.org/show_bug.cgi?id=254073
>
>
> John Layt <john@layt.net> changed:
>
> What |Removed |Added
> ---------------------------------------------------------------------------
> - Status|ASSIGNED |RESOLVED
> Version Fixed In| |4.6.2
> Resolution| |FIXED
>
>
>
>
> --- Comment #8 from John Layt <john layt net> 2011-02-26 00:45:36 ---
> Git commit 4454ec0fd2901861b9e7f1283321e16a69d3d50b by John Layt.
> Committed on 25/02/2011 at 15:39.
> Pushed by jlayt into branch 'master'.
>
> KHoliday: Add Hong Kong holiday files
>
> Add holiday files for Hong Kong in English and Chinese. Note these
> include holidays in the Chinese lunar calendar which I have provided
> fixed dates for in the period 2000-2010.
>
> BUG: 254073
> FIXED-IN: 4.6.2
>
> FORWARD-PORT: f423c49b4b7b9ab21965ede9551cec0694686536
>
> A +206 -0 kholidays/holidays/plan2/holiday_hk_en-gb [License:
> UNKNOWN] *
> A +206 -0 kholidays/holidays/plan2/holiday_hk_zh-cn [License:
> UNKNOWN] *
>
> The files marked with a * at the end have a non valid license. Please read:
> http://techbase.kde.org/Policies/Licensing_Policy and use the headers which
> are listed at that page.
>
>
> http://commits.kde.org/kdepimlibs/4454ec0fd2901861b9e7f1283321e16a69d3d50b
Also, I find there are lots of mistakes in these files.
I've checked the file and found that the Buddha's birthdays in 2001, 2012 and 2020 are wrong (should be in April instead of May), the Chung Yeung Festival in 2014 is wrong (in 2014, it should be on 2 October instead of 1 November), the Mid-Autumn Festival in 2012 is wrong (as the day after mid-autumn festival overlaps with National Day and that day is a Monday, a supplement holiday is given after that day). http://hk.news.yahoo.com/政府公布2013公眾假期-035617225.html Starting from 2013, the rule for reassigning holiday when it is on Sunday is changed. The supplement will always be after the Sunday and no longer on Saturday. Created attachment 70703 [details]
Holiday file for Hong Kong SAR(China) (ENGLISH)
Created attachment 70704 [details]
Holiday file for Hong Kong SAR(China) (CHINESE)
|