| Summary: | Amarok queued track number does not fit in small green circle | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Paul <evoke> |
| Component: | Playlist | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED FIXED | ||
| Severity: | task | CC: | f.riccardo87, nhn, ognyan_angelov, teo |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | 2.6-git | Flags: | myriam:
Usability?
|
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/amarok/4da6e0d09942c4dc674de93c37481817ffb751dc | Version Fixed In: | 2.7 |
| Sentry Crash Report: | |||
| Attachments: |
Green highlights missing digits
Possible solution |
||
Setup: Amarok 2.3.2 KDE 4.4.5 Test Result: Confirm. adding less then 100 in queue is Ok. But more then 100 makes hard to read the queue number in the green dot! Bump version This is an automated message from the triager: Amarok 2.4.1 has been released on May 8 already. Could you please upgrade and test if you can still reproduce this bug? Without feedback within a month we will close this bug as resolved. Thank you for your understanding. The problem still exists after my upgrade to: Amarok 2.4.1 KDE 4.6.3 Still valid in current git I've tried solving the problem like in the second picture Created attachment 75891 [details]
Possible solution
I've painted the green spot by hand scaling it based on the number to display, is this a valuable solution?
Notice: this bug is currently worked on, see also https://git.reviewboard.kde.org/r/107796/ Git commit 4da6e0d09942c4dc674de93c37481817ffb751dc by Matěj Laitl. Committed on 10/01/2013 at 12:08. Pushed by laitl into branch 'master'. PrettyItemDelegate: fix visual overflow of the queued track indicator This is a slightly tweaked version (visually and behaviourally) of Riccardo Ferrazzo's patch, thanks for it! BUGFIXES: * Fix queued track indicator overflow, patch by Riccardo Ferrazzo. FIXED-IN: 2.7 REVIEW: 107796 M +1 -0 ChangeLog M +0 -72 src/images/default-theme-clean.svg M +0 -68 src/images/default-theme.svg M +22 -5 src/playlist/view/listview/PrettyItemDelegate.cpp http://commits.kde.org/amarok/4da6e0d09942c4dc674de93c37481817ffb751dc |
Created attachment 52403 [details] Green highlights missing digits Version: 2.3.1 (using KDE 4.4.5) OS: Linux Queueing more than a few tracks makes the green circle displaying the position of a track in the queue useless. The queue number does not fit in the green highlighted area and is cropped to the last digit making it useless. Reproducible: Always Steps to Reproduce: Queue 10 or more tracks so that the queued track number has more than one digit. Actual Results: Only the last digit is displayed and a ugly cut from the second to last digit. Expected Results: The entire queued track number should be displayed within a larger green highlight.