| Summary: | Filter brush doesn't respect transparency | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | animtim |
| Component: | Brush engines | Assignee: | LukasT <lukast.dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dimula73, halla, lukast.dev, user581 |
| Priority: | NOR | ||
| Version: | git master (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/calligra/36ea0cacad1a3bd87ce655c537064261fd5cf46e | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
animtim
2010-09-30 17:14:37 UTC
This bug is probably the same as the smudge one and as this one https://bugs.kde.org/show_bug.cgi?id=217124 Yes it's the same bug. I've reported more infos as you asked in bug https://bugs.kde.org/show_bug.cgi?id=217124 *** Bug 264196 has been marked as a duplicate of this bug. *** probably needs the the plassy treatment :-) Git commit 6d9415f158e6de80ef8ddd0765b4c1599dbae624 by Lukáš Tvrdý. Committed on 07/07/2012 at 16:29. Pushed by lukast into branch 'master'. Enable composite and opacity options for filter brush o probably forgotten port since commit 19a60300a5507ec5e31a0e3389aed85956f66d10 o composite op support is important for some filters, see commit 36bb81fbf5fac9da1186186c5ba31c284d712b1e M +2 -2 krita/plugins/paintops/filterop/kis_filterop.cpp M +4 -1 krita/plugins/paintops/filterop/kis_filterop_settings_widget.cpp http://commits.kde.org/calligra/6d9415f158e6de80ef8ddd0765b4c1599dbae624 @Animtim: can you try to play with the Filter op in the "COPY" composite mode if that is desired behaviour? There are some extra transparent pixels copied currently but we can prevent them using mask when compositing. Is this bug still actual? I tested it a bit and it looks like the filter just paints above the source layer with a filtered source. So that the opacity gets a bit higher due to that, but it doesn't become fully opaque. Animtim, could you tell what behavior do you expect? @Dmitry: yes this bug is still actual. For example, if I paint with a blur filter brush, I expect it to apply a blur filter on the painted area (and so keeping it's transparency similar, just blurred..), not to paint-over a blurred version of the layer content. @LukasT: I tried with "copy" blending mode, doesn't work right at all (I think I answered this request on IRC when you asked it, I should have pasted it here too). Hm... Probably, you should use the Filter Mask instead. But then I don't know what is the usecase for the filter brush For instance, adding a bit of a blur in a freehand style, or painting with the dodge and burn filters. Ok, there is another bug, actually. The Blur filter paints with an offset. Probably, due to need-rect offset. Git commit 36ea0cacad1a3bd87ce655c537064261fd5cf46e by Dmitry Kazakov. Committed on 22/04/2013 at 13:07. Pushed by dkazakov into branch 'master'. Fixed three bugs and add a feature to KisFilterOp 1) Fixed painting on semi-transparent images. Now COMPOSITE_COPY is the default mode and it works nicely! 2) Added a feature: Smudge Mode for the Filter Op. The temporary device is not cleared every time, which creates really nice effects. 3) Fixed loading of the default filter configuration for the Filter Op 4) Fixed an offset bug when painting with Gaussian Blur. M +- -- krita/plugins/paintops/defaultpresets/filter.kpp M +31 -37 krita/plugins/paintops/filterop/kis_filterop.cpp M +3 -1 krita/plugins/paintops/filterop/kis_filterop.h M +6 -3 krita/plugins/paintops/filterop/kis_filterop_settings_widget.cpp M +2 -2 krita/plugins/paintops/libpaintop/forms/wdgfilteroption.ui M +5 -7 krita/plugins/paintops/libpaintop/kis_filter_option.cpp M +2 -5 krita/plugins/paintops/libpaintop/kis_filter_option.h M +4 -2 krita/ui/kis_paintop_box.cc http://commits.kde.org/calligra/36ea0cacad1a3bd87ce655c537064261fd5cf46e |