Bug 252671

Created attachment 52053 [details]
Patch

Luc,

You have set digiKam target as 2.0.0. Do you build this patch against svn trunk or the GSoC 2010 branche ?

Gilles Caulier

I take a look in your current patch. Your coding style is fine for me. It's very appreciate... (:=)))

Gilles Caulier

Created attachment 52169 [details]
New revision

Hi Gilles,

No I made a mistake, the patch must be apply on trunk, not on the GSOC branch...

Here is a new revision, changes are :
- Put the thumbnails bar back in albumwidgetstack
- Remove filter / zoom / navigations buttons from the status bar

Luc

Great. I take a look

Gilles

Marcel,

[gilles@localhost digikam]$ patch -p0 < digikam_navigationbar5.diff 
patching file CMakeLists.txt
patching file digikam/digikamview.cpp
patching file digikam/digikamapp.h
patching file digikam/mediaplayerview.cpp
patching file digikam/albumwidgetstack.h
patching file digikam/navigationbar.cpp
patching file digikam/digikamapp_p.h
patching file digikam/digikamview.h
patching file digikam/imagepreviewview.h
patching file digikam/imagepreviewview.cpp
patching file digikam/navigationbar.h
patching file digikam/digikamapp.cpp
patching file digikam/albumwidgetstack.cpp

The patch touch some which which have changed indeep in GSoC2010 branch. patch need to be adjusted...

Gilles Caulier

Luc,

My remarks :

1/ Undock navigation bar : floating bar created is completly broken. Can you reproduce it ?
2/ There is no "View" menu entry to show/hide navigation bar.
3/ when you switch from iconview to preview mode, the filter widget (text, rating, mime type) is replaced by navigation buttons. This remove the way to filter thumbbar content in preview mode. This is weird. Filters widget need to still visible. move naviguation button just behing, on the left side of "back to album" button

Gilles Caulier

Luc,

Another point : "View", "Edit", and "Slideshow" button from naviguate bar are dupplicates of application button bar. Why ?

Gilles Caulier

Created attachment 52173 [details]
nav bar undocked and broken

Created attachment 52174 [details]
nav bar in iconview

Created attachment 52175 [details]
nav bar in preview mode

Luc,

Your patch introduce a lots of change in Album GUI. Also, it will require more work to backport and maintain both code (trunk+GOsC2010 branch) at the same time.

So, i would to see this patch only applied on GOsC2010 branch, available there :

http://websvn.kde.org/branches/extragear/graphics/

I would to see 1.x code (trunk) with the same Album GUI interface now...

Thanks in advance

Gilles Caulier

Luc, 

Another viewpoint about your navigation bar : look Dolphin, which has a filter bar on the bottom of icon view. This bar can be enabled/disabled from View menu.

The bar is small and do not reduce a lots the space for icon view.

Your bar include filter + navigation tools. I recommend to separate both feature and create :

- One navigation bar.
- One filter bar. 

The advantage is to select the bar depending of the context and use case, without to reduce icon view text. Of course both can be enabled at the same time.

There is also another point to include there. In Filter bar, later, we will host a combo box with tag filters. This mean that tag filters currently hosted in right sidebar will be removed. Look there :

https://bugs.kde.org/show_bug.cgi?id=210576

Also, new filters will be implemented later, as camera type, aspect ratio, sizes, etc. Look these entries for details :

https://bugs.kde.org/show_bug.cgi?id=124890
https://bugs.kde.org/show_bug.cgi?id=121313
https://bugs.kde.org/show_bug.cgi?id=224549


The is another point to separate navigation and filter tools : a lots of users want to customize filter by album. Typically, we will store in database the filters properties for each album....

Gilles Caulier

Created attachment 52196 [details]
Patch

Hi,

1/ Undock navigation bar : floating bar created is completly broken. Can you
reproduce it ?
--> Done

2/ There is no "View" menu entry to show/hide navigation bar.
--> Done

3/ when you switch from iconview to preview mode, the filter widget (text,
rating, mime type) is replaced by navigation buttons. This remove the way to
filter thumbbar content in preview mode. This is weird. Filters widget need to
still visible. move naviguation button just behing, on the left side of "back
to album" button
--> Done. The navigation buttons are centered and always visibles (even in iconview).

For your question :
"View", "Edit", and "Slideshow" button from naviguate bar are
dupplicates of application button bar. Why ?
I put them in the dock bar because I think that with rotate and delete buttons, they are the most importants actions. Normal user should find quickly what they want to do.
But I let them in the Toolbar for "old users" ;-)
Have you an idea about that ?

(In reply to comment #13)
> Luc, 
> 
> Another viewpoint about your navigation bar : look Dolphin, which has a filter
> bar on the bottom of icon view. This bar can be enabled/disabled from View
> menu.
> 
> The bar is small and do not reduce a lots the space for icon view.
> 
> Your bar include filter + navigation tools. I recommend to separate both
> feature and create :
> 
> - One navigation bar.
> - One filter bar. 
> 
> The advantage is to select the bar depending of the context and use case,
> without to reduce icon view text. Of course both can be enabled at the same
> time.
> 
> There is also another point to include there. In Filter bar, later, we will
> host a combo box with tag filters. This mean that tag filters currently hosted
> in right sidebar will be removed. Look there :
> 
> https://bugs.kde.org/show_bug.cgi?id=210576
> 
> Also, new filters will be implemented later, as camera type, aspect ratio,
> sizes, etc. Look these entries for details :
> 
> https://bugs.kde.org/show_bug.cgi?id=124890
> https://bugs.kde.org/show_bug.cgi?id=121313
> https://bugs.kde.org/show_bug.cgi?id=224549
> 
> 
> The is another point to separate navigation and filter tools : a lots of users
> want to customize filter by album. Typically, we will store in database the
> filters properties for each album....
> 
> Gilles Caulier

I see...
But both bar need to be in the same widget, because we cannot have several QDockWidget, one above the other. (Or I don't know how to do that).

Maybe one QDockWidget, but with buttons to enable filters bar / navigation bar etc... like in kate with the green arrow on the right to switch to "power search".
The thumbnails bar could merge in the same way

Created attachment 52197 [details]
dolphin filter bar

This is the dolphin filter bar set on through Tools menu entry (i think this menu entry is wrong, and View is more appropriate)

Look like this tool bar is not dockable. It always appear at the same place. I think it's enough.

This is the right way for digiKam i think. This solve the way to create more than one bar at the same time : navigate bar and filter bar.

This is my proposal : create a navigate bar on the bottom of icon-view and create the filter on the top of icon-view to be near of album title bar.

Note : i don't yet tested your new patch.

Gilles Caulier

Another point : as cameragui, image editor and litgh-table have the zoom slider on the right corner of statusbar, i think it must be the same for album gui to have an homogenous interface everywhere. This must mean to extract zoom bar from your navigate bar and to restore it to status bar.

Gilles Caulier

Luc,

What's about this file.

Please review it against 2.x code from git repository, where is move all icon view filters to right sidebar.

http://www.flickr.com/photos/digikam/5453984332/sizes/o/in/photostream/

Thanks in advance

Gilles Caulier

Luc,

No new patch version available ?

Gilles Caulier

Hi Gilles,

I started to make the patch works with digikam 2.5, but finally I stopped because it was not very useful...
The dockbar takes space but can't completly replaces the toolbar and the status bar (particularly with the new digikam version), so it wastes space. The only good point I found is the better visibility of the differents possibles actions.

Perhaps it's a better idea to just improve the overlays buttons to make them more visible ?

I think we could close this bug report.

(I hope it's clear but I'm not sure :-) )
Happy christmas.