| Summary: | Plasma desktopthemes installed using GHNS cannot be removed | ||
|---|---|---|---|
| Product: | [Unmaintained] plasma4 | Reporter: | Gökçen Eraslan <gokcen.eraslan> |
| Component: | desktop | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | annma, aseigo, asraniel, toddrme2178 |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | PiSi Linux | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Gökçen Eraslan
2010-09-28 08:42:54 UTC
there is a problem in 4.5.1 with ghns, fixed in 4.5.2 that is not yet released. please test again as soon as it is released. (In reply to comment #1) > there is a problem in 4.5.1 with ghns, fixed in 4.5.2 that is not yet released. > please test again as soon as it is released. Can you say which commit fixes this? Or any related but reports including BUG:XXX? *** This bug has been marked as a duplicate of bug 249980 *** This is not the same bug! Can you please read the issue carefully? I say I _can_ install new desktop themes, but cannot remove them. And my output is not related to the bug you mentioned. I've applied this commit[1]. This is not a duplicate bug. By the way, I'm the one who mentioned about #249980 in core-devel list, if you look here[2] [1] http://websvn.kde.org/?view=revision&revision=1171340 [2] http://lists.kde.org/?l=kde-core-devel&m=128351498507245&w=2 >This is not the same bug! Can you please read the issue carefully? I say I
>_can_ install new desktop themes, but cannot remove them. And my output is not
>related to the bug you mentioned.
i read it, and for me it is related because both seem to have a problem with zip files in nearly the same context, so they seem related.
Anyway, please report back anyway when you tested with 4.5.2
Confirmed on 4.5 branch, desktop themes are not uninstalled. SVN commit 1181725 by aseigo: support tarballs as well, since Plasma::Package does BUG:252612 M +20 -5 packagestructure.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1181725 the problem wasn't that KZip was broken, it's that people are distributing themes as tarballs rather than zip files. looking at the output made this evident: plasmapkg(1632)/KZip KZip::openArchive: Invalid ZIP file. Unexpected end of file. and then look at the name of the file: plasmapkg(1632)/libplasma Plasma::PackageStructure::metadata: Could not open package file: "/tmp/kde-gokcen/129936-Blue-Air-1.2.tar.gz" so the problem is (was) in Plasma::PackageStructure::metadata, and it was that it was feeding a tarball to KZip. Plasma::Package auto-detects and handles zip or tarball archives, and now so does PackageStructure. this makes sense from a symmetry POV, though i might have expected people making themes to try testing things out they give to others. ah, right, who does that? ;P What about application/x-gzip mimetype? When I look a tar.gz file with "file a.tar.gz -i" command I get, application/x-gzip. Plasma::Package class also does not handle application/x-gzip mimetype but, I just want to say that. By the way can you backport this to 4.5 branch? Hmm I think this bug is not fixed yet. I still cannot remove desktopthemes with tar.gz tarballs. I've installed Ember desktoptheme succesfully but still cannot remove it. Here is the output: plasmapkg(5316)/kdecore (KSycoca): Trying to open ksycoca from "/var/tmp/kdecache-gokcen/ksycoca4" plasmapkg(5316)/kdecore (services): Now parsing "/usr/share/mime/magic" plasmapkg(5316)/kdecore (services): Now parsing "/usr/kde/4/share/mime/magic" plasmapkg(5316)/kdecore (services): Now parsing "/home/gokcen/.local/share/mime/magic" plasmapkg(5316)/KTar KTar::createDevice: mimetype= "application/x-gzip" plasmapkg(5316)/KTar KTar::createDevice: creating tempfile: "/tmp/kde4-gokcen/ktar-Wy5316.tar" plasmapkg(5316)/KTar KTar::KTarPrivate::fillTempFile: filling tmpFile of mimetype "application/x-gzip" plasmapkg(5316)/kdecore (kdelibs): KTempDir: Temporary directory created : "/tmp/kde-gokcen/plasmapkgqWmE0U/" plasmapkg(5316)/libplasma Plasma::PackageStructurePrivate::createPackageMetadata: No metadata file in the package, expected it at: "" plasmapkg(5316)/kdecore (kdelibs): "/tmp/kde-gokcen/plasmapkgqWmE0U/" This is still a problem in 4.6 RC 1. I think this is a duplicate of Bug 224745 This seems to be fixed, and if not it is a duplicate. Git commit 6ed9229f4b2df1d98821bef5ab7a361b5dea9ffa by Aaron Seigo. Committed on 03/12/2011 at 17:45. Pushed by aseigo into branch 'KDE/4.7'. catch another possible mimetype identification BUG:252612 M +1 -1 plasma/packagestructure.cpp http://commits.kde.org/kdelibs/6ed9229f4b2df1d98821bef5ab7a361b5dea9ffa |