Summary: | Allow user to set custom icon | ||
---|---|---|---|
Product: | [Applications] kdialog | Reporter: | Kai Uwe Broulik <KaiUweBroulik2> |
Component: | general | Assignee: | Brad Hards <bradh> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | achrislong, cfeck |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 4.7.0 | |
Sentry Crash Report: | |||
Attachments: | Patch to enable --icon to affect passivepopup as well |
Description
Kai Uwe Broulik
2010-09-22 15:58:31 UTC
Addition: The KDE option --icon does set an icon but only for the dialogs, notifications are untouched by that parameter. No change with the new notification system in 4.6 unfortunately. Now you have that big fat info-icon that spits in your face ;) Created attachment 59569 [details]
Patch to enable --icon to affect passivepopup as well
I just discovered notify-send works fine for notifications with icons but I definitly want that in kdialog as well.
So I looked at the code and found what was responsible and added something. I couldn’t compile it (have no real development environment or dependencies set up) and I don’t know if this is the correct approach but I would appreciate it if you have a look at it.
(I wanted to push it to reviewboard but the identity.kde.org activation mail somehow got lost or is not yet arrived or whatever, so I post it here, first)
I had a quick look at the patch (didn't try it), and it looks ok. I'd encourage you to build / test it. There are instructions on community.kde.org and techbase.kde.org for how to set up a development environment. I just changed something since that --icon parameter doesn’t turned out correctly and so I added --passiveicon for the icon of passivepopup. I compiled it and it works as expected :) Yay! :D It’s in the reviewboard: https://git.reviewboard.kde.org/r/101282/ Git commit 8953d76773a39a756513280a04409f8984840268 by Christoph Feck. Committed on 10/05/2011 at 12:37. Pushed by cfeck into branch 'master'. Fix passive popup messages * --icon argument did not work * fallback to old style popups was broken because of a timer issue Investigations and patch by Kai-Uwe Broulik, thanks! REVIEW: 101282 Minor comment cleanup by me FIXED-IN: 4.7.0 BUG: 252050 M +45 -19 kdialog/kdialog.cpp http://commits.kde.org/kde-baseapps/8953d76773a39a756513280a04409f8984840268 *** Bug 395030 has been marked as a duplicate of this bug. *** |