Summary: | Font Installer crashes after repeatedly pressing escape | ||
---|---|---|---|
Product: | [Applications] systemsettings | Reporter: | Andy <tipul07> |
Component: | kcm_fontinst | Assignee: | Craig Drummond <craig> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | cfeck |
Priority: | NOR | ||
Version: | 1.0 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Andy
2010-09-20 17:38:23 UTC
Caused by KFI::CJobRunner::exec() spawning a nested event loop, which allows the user to manipulate the UI. During exec() a modal progress dialog should be shown, or the nested event loop avoided. Git commit cb3fd3ec3ef6ee2831743559f0221781037a3c1a by Craig Drummond. Committed on 24/06/2011 at 18:37. Pushed by craig into branch 'KDE/4.6'. Dont spwan a nested QEventLoop - not really required. BUG:251832 M +45 -53 kcontrol/kfontinst/kcmfontinst/JobRunner.cpp M +2 -3 kcontrol/kfontinst/kcmfontinst/JobRunner.h http://commits.kde.org/kde-workspace/cb3fd3ec3ef6ee2831743559f0221781037a3c1a Git commit 36ab80448a78a65e58390cb7db0624cd344f6da7 by Craig Drummond. Committed on 24/06/2011 at 18:40. Pushed by craig into branch 'master'. Dont spwan a nested QEventLoop - not really required. BUG:251832 M +50 -55 kcontrol/kfontinst/kcmfontinst/JobRunner.cpp M +2 -3 kcontrol/kfontinst/kcmfontinst/JobRunner.h http://commits.kde.org/kde-workspace/36ab80448a78a65e58390cb7db0624cd344f6da7 Thanks. Since 4.7 is branched, it might make sense to also backport to KDE/4.7. Git commit bbc2b5f86a0e3501759309deb82382e61d057307 by Craig Drummond. Committed on 25/06/2011 at 11:52. Pushed by craig into branch 'KDE/4.7'. Dont spwan a nested QEventLoop - not really required. BUG:251832 M +50 -55 kcontrol/kfontinst/kcmfontinst/JobRunner.cpp M +2 -3 kcontrol/kfontinst/kcmfontinst/JobRunner.h http://commits.kde.org/kde-workspace/bbc2b5f86a0e3501759309deb82382e61d057307 > --- Comment #4 from Christoph Feck <christoph maxiom de> 2011-06-25
> 07:03:38 --- Thanks. Since 4.7 is branched, it might make sense to also
> backport to KDE/4.7.
Thanks for the reminder!! I've just 'pushed' the change.
|