| Summary: | Editing default layout: Change still shown in layout editor, and copy does not work | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Ralf Jung <post> |
| Component: | Playlist/Playlist Layout Editor | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nhn, niko.vuokko |
| Priority: | NOR | ||
| Version: | 2.6-git | ||
| Target Milestone: | 2.7 | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/amarok/fc04548aa90b7130b023b001cb2977b50864117c | Version Fixed In: | 2.8 |
| Sentry Crash Report: | |||
|
Description
Ralf Jung
2010-09-08 20:12:20 UTC
I have this one too in 2.3.2 (4.5.4). Tried adding Rating field just before song length to the Default layout, but it never works. The only modification that works seems to be the 'Show cover' tick box. Adding or removing fields doesn't work. Confirmed and bumping version. I updated to Amarok 2.4.0, the bug is still around. This is an automated message from the triager: Amarok 2.4.1 has been released on May 8 already. Could you please upgrade and test if you can still reproduce this bug? Without feedback within a month we will close this bug as resolved. Thank you for your understanding. Closing for lack of feedback. Feel free to reopen if you can still reproduce this with Amarok 2.4.2 beta 1 or later and provide the necessary feedback. As mentioned in 272471 and via private email, I won't be able to update to a later version of Amarok before the end of the semester. I can't afford my PC stopping to work, and Amarok is not available for my current distribution. I plan to update to Debian Testing in two weeks, which will give me Amarok 2.4.1. You don't seriously expect me to update to a beta version to keep this bug valid, do you? Sorry, but since you didn't reply here this was closed automatically. Reopening. Things changed slightly with Amarok 2.4.1 on Debian testing: The actual playist now looks correct when choosing the copy. However, in the playlist layout editor, when the original layout is selected, it still incorrectly shows the modification. Thank you for the feedback. This still happens with Amarok v2.6.0. I really wonder why nobody can reproduce this, as I saw this on three machines now, no matter whether I used Debian packages or compiled all the stuff (including kdelibs) myself, no matter how often I reset my entire KDE configuration. (In reply to comment #10) > This still happens with Amarok v2.6.0. > I really wonder why nobody can reproduce this, as I saw this on three > machines now, no matter whether I used Debian packages or compiled all the > stuff (including kdelibs) myself, no matter how often I reset my entire KDE > configuration. Well, in comment #1 and #2 you can see that this was confirmed, so we know about the problem. But the issue here is that we currently don't have a maintainer for that code and we use our resources for more important fixes for now. What I have found is that as soon as you try to put more than 3 items on a line it has problems, and modifying the automatic width to a manual one has solved the problem for me in most cases. (In reply to comment #11) > Well, in comment #1 and #2 you can see that this was confirmed, so we know > about the problem. But the issue here is that we currently don't have a > maintainer for that code and we use our resources for more important fixes > for now. Sorry, I was not aware (or forgot) that there is no "CONFIRMED" state here, and "NEW" means the bug is confirmed. > What I have found is that as soon as you try to put more than 3 items on a > line it has problems, and modifying the automatic width to a manual one has > solved the problem for me in most cases. On my system, the bug is not at all related to having more than three items on a line. It does not matter which modification I do in the original layout. I was wondering: does the Default layout still show the change after a restart? I think this is just a caching issue as you can not change the default ones anyway. (In reply to comment #13) > I was wondering: does the Default layout still show the change after a > restart? No, a restart reverts whatever changes I (seemingly) did. Also, the change is not actually applied when using the layout for the playlist, it's just shown in the editor. Git commit fc04548aa90b7130b023b001cb2977b50864117c by Ralf Engels. Committed on 01/02/2013 at 20:56. Pushed by rengels into branch 'master'. Fix Editing default layout: Change still shown in layout editor FIXED-IN: 2.8 M +24 -20 src/playlist/layouts/PlaylistLayoutEditDialog.cpp M +3 -0 src/playlist/layouts/PlaylistLayoutEditDialog.h http://commits.kde.org/amarok/fc04548aa90b7130b023b001cb2977b50864117c |