Bug 250118

Summary:	KIO::AccessManager::createRequest does not handle all operations
Product:	[Unmaintained] kio	Reporter:	Andrea Diamantini <adjam7>
Component:	general	Assignee:	David Faure <faure>
Status:	RESOLVED FIXED
Severity:	normal	CC:	adawit, evan
Priority:	NOR
Version:	SVN
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:	4.5.4
Sentry Crash Report:
Attachments:	kio accessmanager createrequest patch

Description Andrea Diamantini 2010-09-04 01:32:38 UTC

Created attachment 51293 [details]
kio accessmanager createrequest patch

Version:           SVN (using Devel) 
OS:                Linux

the switch(op) in KIO::accessmanager::createRequest method does not handle all QNAM::operation(s), returning 0 when a custom or a delete one is called. This lets happily crash QtWebKit :)
An example site of this behaviour is http://www.sfx.co.uk/2010/08/26/from-the-sfx-office-25/ as explained in bug:249275.
The attached patch, similar to the one used in rekonq to address the issue, should workaround the problem, waiting for a "proper fix". 

Reproducible: Didn't try

Comment 1 Andrea Diamantini 2010-09-10 12:13:31 UTC

Dawit?

Comment 2 Dawit Alemayehu 2010-11-06 18:38:10 UTC

For some reason I did not see this bug until now nor did I recieve the notification though my email address is in the CC list. Anyhow, it will be fixed shortly...

Comment 3 Dawit Alemayehu 2010-11-06 19:16:53 UTC

SVN commit 1193664 by adawit:

- Added support for missing QNAM DeleteOperation.
- Let QNAM handle all operations not supported by KIO, e.g. CustomOperation.

BUG:250118


 M  +13 -6     accessmanager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1193664

Comment 4 Dawit Alemayehu 2010-11-06 19:25:18 UTC

SVN commit 1193669 by adawit:

Backported the fix for unhandled QNAM operations that cause QtWebKit to crash.

CCBUG:250118

 M  +9 -3      accessmanager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1193669

Comment 5 Dawit Alemayehu 2010-11-13 08:26:28 UTC

*** Bug 242141 has been marked as a duplicate of this bug. ***