Bug 249787

Summary: Make showing keyboard shortcuts (mnemonics, accelerators) configurable
Product: [Plasma] Oxygen Reporter: Metin Amiroff <amiroff>
Component: styleAssignee: Hugo Pereira Da Costa <hugo.pereira.da.costa>
Status: RESOLVED FIXED    
Severity: wishlist CC: amiroff, hugo.pereira.da.costa, joshua.rickmar
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Accelerators make UI look cluttered and busy
oxygeb-settings

Description Metin Amiroff 2010-09-01 21:53:53 UTC
Created attachment 51194 [details]
Accelerators make UI look cluttered and busy

Version:           unspecified (using KDE 4.5.0) 
OS:                Linux

While keyboard mnemonics displayed everywhere are good for usability, at the same time they clutter interface. KDE would look much cleaner with mnemonics hidden by default. Maybe a 3 option menu could be developed:
- Always Hide Accelerators
- Always Display Accelerators
- Display Accelerators on Alt button press

Gnome, Windows and OsX do not display accelerators by default, and it would be very good if KDE provided us with options about these.

Thank you.

Reproducible: Always
Comment 1 Hugo Pereira Da Costa 2010-09-02 06:55:04 UTC
Actually, I would rather have Qt providing us with an option for this, that would then be consistently enforced by all styles, and using a unique global settings. 

Now, options 
- "Always Hide Accelerators"
- "Always Display Accelerators"
are fairly easy to implement inside oxygen 
- "Display Accelerators on Alt button press" is not. (at least it does not seem easy *to me*

Because of the above, if this is to be implemented in oxygen, the default would still be "always display accelerators" (because they have their use).
And the option to hide them would only be in the expert tool (in order to clutter in the 'minimal' config). 

Aside from the above, I have no other objections. (and as a matter of fact, I tested the no accelerator locally, and agree it looks nice). 

I'll ask around (on IRC) about opinions on the subject. since strictly speaking, I don't think it is the style's scope to enforce the accelerator policy.
Comment 2 Metin Amiroff 2010-09-02 09:43:16 UTC
Hugo, thanks for informative feedback. 

I also agree, QT providing this feature would be the best. Still, it could take many months/years to develop it, so I think a little help from Oxygen could help in the short run. 

At least for the easy part you're mentioning, we do not need any guis at all, just like gtk apps hide their mnemonics with a simple setting (gtk-enable-mnemonics = 0) in .gtkrc file, a similar setting for KDE would be sufficient.

Also, I tend to differ about the usefulness of displaying mnemonics by default, as 9 out of 10 tech savvy people I questioned did know (or guess) what they are, but had no idea on how to use them. But, again, it's just my opinion.
Comment 3 Hugo Pereira Da Costa 2010-09-08 23:04:56 UTC
SVN commit 1173172 by hpereiradacosta:

Added 'expert' option to disable keyboard accelerators.
BUG: 249787


 M  +4 -0      config/main.cpp  
 M  +5 -0      config/oxygenstyleconfig.cpp  
 M  +13 -6     config/ui/oxygenstyleconfig.ui  
 M  +3 -0      oxygen.kcfg  
 M  +15 -4     oxygenstyle.cpp  
 M  +3 -0      oxygenstyle.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1173172
Comment 4 Metin Amiroff 2010-09-10 04:04:00 UTC
Hugo, thank you very much for this commit. I'm sure users will appreciate it, I surely do.
Comment 5 Metin Amiroff 2010-10-12 11:57:28 UTC
Hugo, is this fix in the latest KDE 4.5.2? If so, could you be kind to provide instructions on how to disable showing mnemonics?

Thanks.
Comment 6 Hugo Pereira Da Costa 2010-10-12 15:53:41 UTC
Argh. No its not in 4.5.2
My thinking was that since I had to add an option (in expert tool) to handle that, which breaks "string freeze" for the 4.5 series, I could only add it in for kde4.6

Now, thinking more (!), I can still backport a hidden option in 4.5, which therefore would not break string freeze, Although, technically, this is not a bug fix but rather a new feature, so that in principle it should not be backported either. 

I'll ask around and will come back to you
Comment 7 Metin Amiroff 2011-01-07 15:51:48 UTC
Hugo,

Can you provide some details about how to hide mnemonics in latest KDE 4.6RC? oxygen-settings does not seem to have any visible changes.

Thanks!
Comment 8 Hugo Pereira Da Costa 2011-01-07 15:54:06 UTC
On Friday, January 07, 2011 03:51:51 pm Metin Amiroff wrote:
> https://bugs.kde.org/show_bug.cgi?id=249787
> 
> 
> 
> 
> 
> --- Comment #7 from Metin Amiroff <amiroff gmail com>  2011-01-07 15:51:48
> --- Hugo,
> 
> Can you provide some details about how to hide mnemonics in latest KDE
> 4.6RC? oxygen-settings does not seem to have any visible changes.
> 

it should be in the first page, unchecking "draw keyboard accelerators".
Is it not there ? 

> Thanks!
Comment 9 Hugo Pereira Da Costa 2011-01-07 15:55:43 UTC
Created attachment 55693 [details]
oxygeb-settings

See the second checkbox from the top.
Comment 10 Metin Amiroff 2011-01-07 16:14:15 UTC
I am sorry for wasting your time, I'm getting blind :(

Thanks for this feature again!
Comment 11 Christoph Feck 2013-12-30 03:07:17 UTC
*** Bug 155791 has been marked as a duplicate of this bug. ***