| Summary: | Don't expose Konsole actions to hosting application | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | Mathias Homann <Mathias.Homann> |
| Component: | kpart | Assignee: | Konsole Developer <konsole-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | a.badger, ciro.santilli, dsamoyloff, sobik2, the.rhorn |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Unlisted Binaries | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 4.9.0 | |
| Sentry Crash Report: | |||
|
Description
Mathias Homann
2010-08-20 09:16:18 UTC
This is a bug in Konsole that causes its shortcuts to be exposed in the Konsole KPart component which Yakuake embeds, when they shouldn't be. The only thing you can do is change the shortcuts in Konsole, sorry. i already thought of that and tried it. in konsole, those hotkeys are set to "NONE" for me, and still yakuake does the font thing. Then Konsole may have changed recently so it not only exposes its shortcuts in its KPart but doesn't load the settings values, so they're always the defaults. Yakuake's codebase has no functionality to change the font size in any way (the terminal area is provided by the Konsole KPart component, which has no API by which the hosting application could manipulate the terminal font anyway). What I can do is blacklist and disable the actions from the Yakuake side, I've already done that for some other actions. But this really is a Konsole bug, so I'll reassign it there. For the technical record: The actions that Konsole pollutes the hosting app's "namespace" with aren't even in the KPart's actionCollection(). SVN commit 1165837 by hein: Blacklist Konsole's font actions. CCBUG:248469 M +6 -0 terminal.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1165837 strangely enough in konsole itself those keyboard shortcuts do not work anymore after i switched them off... so i guess its only the konsole KPART that does not read its settings properly, or sumthin like that. *** Bug 254472 has been marked as a duplicate of this bug. *** (In reply to comment #4) > SVN commit 1165837 by hein: > > Blacklist Konsole's font actions. > > CCBUG:248469 > > > M +6 -0 terminal.cpp > > > WebSVN link: http://websvn.kde.org/?view=rev&revision=1165837 The patch didn't helped being applied against yakuake-2.9.7. This bug is a real showstopper for Bash and Emacs(-like) users :-( Yeah, I can confirm that the patch doesn't work, unfortunately. *** This bug has been confirmed by popular vote. *** *** Bug 230915 has been marked as a duplicate of this bug. *** Git commit 08de49da1cf4c89c375d7eea267bce3b46c05527 by Jekyll Wu. Committed on 01/03/2012 at 01:58. Pushed by jekyllwu into branch 'master'. konsolepart should not expose actions only meaningful to Konsole Note: some actions, such as enlarging/shrinking font and setting encoding, might actually be also useful in konsolepart. But since konsolepart currently always use the default shortcut, the general idea now is to expose actions as few as possible in konsolepart. FIXED-IN: 4.9.0 REVIEW: 104034 CCMAIL: hein@kde.org M +43 -32 src/SessionController.cpp M +2 -1 src/SessionController.h http://commits.kde.org/konsole/08de49da1cf4c89c375d7eea267bce3b46c05527 I get the ambiguous action for Ctrl+Shift+W with Yukake + Konsole. This has been opened as a separate report here: https://bugs.kde.org/show_bug.cgi?id=319172 In Yukake, each terminal split inside a tab seems to be a Konsole part and the tabs are managed by Yukake. Intuitively, it is expected that Ctrl+Shift+W closes a Yukake tab like in Konqueror, and this tab may contain many Konsole parts. Interestingly, ctrl-shift-t works as expected in Yukake, so the Konsole part does not expose it. Why should it expose ctrl-shift-w be exposed then, since those actions are somewhat opposite? It seems more logical not to expose ctrl-shift-w as well. |