Bug 248137

Summary:	Adblock does not work with kwebkitpart
Product:	[Frameworks and Libraries] kwebkitpart	Reporter:	David Goller <david.goller>
Component:	general	Assignee:	webkit-devel
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	adawit, frederic.coiffier, m.wege, majewsky, meyerm
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed In:	1.1
Sentry Crash Report:

Description David Goller 2010-08-17 12:57:21 UTC

Version:           4.5.0 (using KDE 4.5.0) 
OS:                Linux

opensuse 11.3, kwebkitpart 0.9, qt 4.6.3
Adblock does not work with kwebkitpart, but with khtml.

Reproducible: Always

Comment 1 Tommi Tervo 2010-08-17 13:41:33 UTC

Sorry for the reassignment hassle, according to other bug reports, adblock should work.

http://bugs.kde.org/show_bug.cgi?id=173271
http://bugs.kde.org/show_bug.cgi?id=198520

Comment 2 Dawit Alemayehu 2010-08-17 18:19:40 UTC

kwebkitpart does use adblock filter plugins to filter requests. However, since the adblock filter plugin has not yet been modified to support kwebkitpart, the newly added automatic filtering feature in that plugin does not work in kwebkitpart. Only the old manual filtering does. For further details of features that are not yet supported in kwebkitpart consult the link below:

http://websvn.kde.org/trunk/extragear/base/kwebkitpart/TODO?view=markup

Comment 3 Dawit Alemayehu 2010-08-17 18:23:14 UTC

*** Bug 240201 has been marked as a duplicate of this bug. ***

Comment 4 Dawit Alemayehu 2010-12-18 05:48:30 UTC

SVN commit 1207438 by adawit:

- Implemented support for the automatic ad filtering feature. Now the automatic
  ad filtering functionality should work exactly as it does in khtml except for
  the UI related stuff. That however is outside the scope of kwebkitpart and 
  needs to be addressed in the adblock plugin itself.

CCBUG:248137


 M  +44 -0     networkaccessmanager.cpp  
 M  +12 -7     networkaccessmanager.h  
 M  +24 -2     settings/khtml_filter.cpp  
 M  +2 -1      settings/khtml_filter_p.h  
 M  +141 -25   settings/webkitsettings.cpp  
 M  +4 -2      settings/webkitsettings.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1207438

Comment 5 Christoph Feck 2010-12-20 01:07:33 UTC

This commit (r1207438) is missing in the repository on git.kde.org. This also affects commits r1206768, r1207436, r1207462.

Comment 6 Urs Wolfer 2010-12-20 07:14:29 UTC

@Christoph: Why should it be on git.kde.org? Do I have missed something?

Comment 7 Frédéric COIFFIER 2011-10-27 08:10:45 UTC

I think this report could be closed as Adblock works with kwebkitpart (tested with last Git version).