| Summary: | patch: fix build of superkaramba on DragonFly | ||
|---|---|---|---|
| Product: | [Unmaintained] superkaramba | Reporter: | Alex Hornung <alexh> |
| Component: | general | Assignee: | Ryan Nickell <p0z3r> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | rakuco |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Other | ||
| Latest Commit: | Version Fixed In: | 4.5.5 | |
| Sentry Crash Report: | |||
| Attachments: |
fix superkaramba compile errors on DragonFly
Link to libkvm on DragonFly. |
||
SVN commit 1188011 by rkcosta: Fix compilation errors on DragonFly BSD. From the bug report description: * add DragonFly preprocessor macro ifs where necessary to make superkaramba work on DragonFly. Patch by Alex Hornung <alexh AT dragonflybsd DOT org> CCBUG: 247790 M +1 -1 python/misc.cpp M +19 -19 sensors/mem.cpp M +3 -3 sensors/mem.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1188011 SVN commit 1188012 by rkcosta: Backport r118011. Fix compilation errors on DragonFly BSD. From the bug report description: * add DragonFly preprocessor macro ifs where necessary to make superkaramba work on DragonFly. Patch by Alex Hornung <alexh AT dragonflybsd DOT org> CCBUG: 247790 M +1 -1 python/misc.cpp M +19 -19 sensors/mem.cpp M +3 -3 sensors/mem.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1188012 The kvm issue can be solved by changing the check in superkaramba/src/CMakeLists.txt. Currently, it links to libkvm only if ${CMAKE_SYSTEM_NAME} begins with "FreeBSD"; this value is usually obtained from uname -a. What does DragonFly return?
1 # uname -a DragonFly dragon.local 2.9-DEVELOPMENT DragonFly v2.9.0.13.gf9527-DEVELOPMENT #65: Wed Oct 20 19:40:31 BST 2010 root@dragon.local:/usr/obj/usr/src/sys/MP i386 Created attachment 52717 [details]
Link to libkvm on DragonFly.
Alex, can you please check if the attached patch fixes the linking problems on DragonFly?
Ping? Sorry Raphael, I am reinstalling the system right now and will be compiling kde over the weekend. I will let you know as soon as I can. Thank you very much for your help Sorry for the long delay, had a busy month. The patch seems to work, thanks! SVN commit 1206477 by rkcosta: Fix build on DragonFly BSD. DragonFly needs to link to libkvm, just like FreeBSD. CCBUG: 247790 M +3 -5 CMakeLists.txt WebSVN link: http://websvn.kde.org/?view=rev&revision=1206477 SVN commit 1206479 by rkcosta: Backport r1206477. Fix build on DragonFly BSD. DragonFly needs to link to libkvm, just like FreeBSD. BUG: 247790 FIXED-IN: 4.5.5 M +3 -5 CMakeLists.txt WebSVN link: http://websvn.kde.org/?view=rev&revision=1206479 |
Created attachment 50509 [details] fix superkaramba compile errors on DragonFly Version: unspecified (using KDE 4.4.5) OS: other * add DragonFly preprocessor macro ifs where necessary to make superkaramba work on DragonFly. * additionally it needs to be linked against libkvm. I'm not familiar with cmake so I can't provide a patch, but it should be straightforward for anyone with the required knowledge about cmake. For reference, I fixed it manually adding -lkvm to _KDE_build/superkaramba/src/CMakeFiles/superkaramba-bin.dir/link.txt Reproducible: Always