Summary: | Dolphin crash (Multiple windows open & file transfer) | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | Josh <jscheel42> |
Component: | general | Assignee: | Peter Penz <peter.penz19> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | benoit.gouhier, franciscoadriansanchez, frank78ac, hein, joethefox, karl_heinz, kourtzis, maximka, rct+bugs, sir_kalot, xavier.besnard |
Priority: | NOR | Keywords: | investigated |
Version: | 16.12.2 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 4.5.1 | |
Sentry Crash Report: | |||
Attachments: | Use a QPointer for DolphinView's m_selectionModel member |
Description
Josh
2010-08-13 10:03:58 UTC
Edit: The file transfer did stop. It stalled and didn't report any errors so I thought it was fine, but it did stop transferring. Thanks for the bug report! Looks like it might be related to bug 245653 and bug 243985. I get a very similar backtrace in current trunk (see below) if I do the following (see bug 245878 comment 1): 1. Open Dolphin (I've set it to remember view properties for all folders). 2. Switch to Icons View (if it's not already in that view mode). 3. Open a subfolder of ~. 4. Switch to Columns View. 5. Open a subfolder of the folder which is open in the view. 6. Switch back to Icons View. 7. Go "Back". It seems that DolphinView's m_selectionModel became a dangling pointer (because the column's selection model has been deleted) which leads to a crash when trying to disconnect its signal. It might help to make it a QPointer or another type of smart pointer. #6 0x00007f20c6a8ce0b in QObject::disconnect (sender=0x8a5e00, signal=0x88a4b9 "selectionChanged(QItemSelection,QItemSelection)", receiver=0xa0fff0, method= 0xa8c109 "slotSelectionChanged(QItemSelection,QItemSelection)") at kernel/qobject.cpp:2722 #7 0x00007f20ca4aa325 in DolphinView::setUrl (this=0xa0fff0, url=...) at /home/kde-devel/kde/src/KDE/kdebase/apps/dolphin/src/views/dolphinview.cpp:562 #8 0x00007f20ca9a7a1d in DolphinViewContainer::slotUrlNavigatorLocationChanged (this=0x7a8f60, url=...) at /home/kde-devel/kde/src/KDE/kdebase/apps/dolphin/src/dolphinviewcontainer.cpp:440 #9 0x00007f20ca9a8745 in DolphinViewContainer::qt_metacall (this=0x7a8f60, _c=QMetaObject::InvokeMetaMethod, _id=19, _a=0x7fff25f28270) at /home/kde-devel/kde/build/KDE/kdebase/apps/dolphin/src/dolphinviewcontainer.moc:139 #10 0x00007f20c6a7992b in QMetaObject::metacall (object=0x7a8f60, cl=QMetaObject::InvokeMetaMethod, idx=46, argv=0x7fff25f28270) at kernel/qmetaobject.cpp:237 #11 0x00007f20c6a8e73d in QMetaObject::activate (sender=0x91c790, m=0x7f20ca220620, local_signal_index=1, argv=0x7fff25f28270) at kernel/qobject.cpp:3272 #12 0x00007f20c9fefd05 in KUrlNavigator::urlChanged (this=0x91c790, _t1=...) at /home/kde-devel/kde/build/KDE/kdelibs/kfile/kurlnavigator.moc:160 #13 0x00007f20c9fee3d9 in KUrlNavigator::goBack (this=0x91c790) at /home/kde-devel/kde/src/KDE/kdelibs/kfile/kurlnavigator.cpp:842 #14 0x00007f20ca99a0af in DolphinMainWindow::goBack (this=0x763a60) at /home/kde-devel/kde/src/KDE/kdebase/apps/dolphin/src/dolphinmainwindow.cpp:832 Created attachment 50728 [details] Use a QPointer for DolphinView's m_selectionModel member This patch fixes it for me. I don't know if it's the "right" way to fix it though: there's still more things going wrong in the Columns View (see bug 245878 comment 2 - this crash remains even with my patch). *** Bug 245653 has been marked as a duplicate of this bug. *** *** Bug 243985 has been marked as a duplicate of this bug. *** *** Bug 247459 has been marked as a duplicate of this bug. *** *** Bug 247849 has been marked as a duplicate of this bug. *** *** Bug 247988 has been marked as a duplicate of this bug. *** *** Bug 248276 has been marked as a duplicate of this bug. *** *** Bug 246805 has been marked as a duplicate of this bug. *** SVN commit 1165532 by ppenz: Fix crash in column view because of a dangling pointer to a selection model. Thanks a lot to Frank Reininghaus for finding a way how to reproduce the issue and analyzing the root cause. Keeping the selection model as part of the DolphinView is not required anymore at all, as the restoring of selected items is done by m_selectedItems in the meantime. CCBUG: 247618 M +21 -22 dolphinview.cpp M +0 -1 dolphinview.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1165532 SVN commit 1165533 by ppenz: Backport of SVN commit 1165532: Fix crash in column view because of a dangling pointer to a selection model. Thanks a lot to Frank Reininghaus for finding a way how to reproduce the issue and analyzing the root cause. Keeping the selection model as part of the DolphinView is not required anymore at all, as the restoring of selected items is done by m_selectedItems in the meantime. BUG: 247618 M +21 -22 dolphinview.cpp M +0 -1 dolphinview.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1165533 *** Bug 245878 has been marked as a duplicate of this bug. *** *** Bug 247822 has been marked as a duplicate of this bug. *** *** Bug 249304 has been marked as a duplicate of this bug. *** *** Bug 249514 has been marked as a duplicate of this bug. *** |