Bug 247466

Summary: Unlocalizable string in Command history
Product: [Applications] umbrello Reporter: Yuri Chornoivan <yurchor>
Component: generalAssignee: Umbrello Development Group <umbrello-devel>
Status: RESOLVED FIXED    
Severity: normal CC: andi.fischer, aspotashev
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Mandriva RPMs   
OS: Linux   
Latest Commit: Version Fixed In:

Description Yuri Chornoivan 2010-08-12 05:53:17 UTC
Version:           unspecified (using KDE 4.4.3) 
OS:                Linux

After changing class properties on diagram in Umbrello, "Command history" shows unlocalized string ("Change Properties").
 
The only place in code with this string is (umbrello/widgets/umlwidget.cpp:285) as follows
 
    case ListPopupMenu::mt_Properties:
        if (wt == wt_Actor || wt == wt_UseCase ||
                wt == wt_Package || wt == wt_Interface || wt == wt_Datatype ||
                wt == wt_Component || wt == wt_Artifact ||
                wt == wt_Node || wt == wt_Enum || wt == wt_Entity ||
                (wt == wt_Class && m_pView->getType() == dt_Class)) {
            UMLApp::app()->beginMacro("Change Properties");
            showProperties();
            UMLApp::app()->endMacro();
        } else if (wt == wt_Object) {
            UMLApp::app()->beginMacro("Change Properties");
            m_pObject->showProperties();
            UMLApp::app()->endMacro();
        } else {
            uWarning() << "making properties dialog for unknown widget type";
        }
        // adjustAssocs( getX(), getY() );//adjust assoc lines
        break;

As it can be seen from the code "Change Properties" is not extracted to POT.

Reproducible: Didn't try

Steps to Reproduce:
1. Open localized version of Umbrello.
2. Add some class.
3. Choose "Properties" from context menu of the new class.
4. Change something in properties.
5. Close properties window.

Actual Results:  
Command history shows unlocalized "Change Properties".

Expected Results:  
Command history shows localized version of "Change Properties".
Comment 1 Andi Fischer 2010-08-29 22:49:37 UTC
Should be fixed by committed revision 1169675.