Bug 246903

Summary: Editor Canvas : not updated when zoom level changes in tools
Product: [Applications] digikam Reporter: Simon <simon.eu>
Component: ImageEditor-CanvasAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, praveshgupta1993
Priority: NOR    
Version: 3.0.0   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: http://commits.kde.org/digikam/6394b9d53c4727c08f5b45c14f5f4871778db465 Version Fixed In: 4.0.0
Sentry Crash Report:

Description Simon 2010-08-06 13:54:54 UTC 
Version:           1.4.0 (using KDE 4.4.5) 
OS:                Linux

To reproduce:
* Open the Curves widget
* Switch the preview mode to Mouse-over mode,
* Change the curve
* Zoom into the image
Now the preview is not shown anymore, no matter where the mouse is.

I was zooming into the image with Ctrl+Wheel. So it does not make sense to recalculate  the preview for each zoom step, only when the mouse leaves the image, which is when the preview should be shown again.

Reproducible: Always




OS: Linux (x86_64) release 2.6.34-0.slh.11-sidux-amd64
Compiler: cc
Comment 1 caulier.gilles 2010-08-17 10:33:04 UTC 
This is not a bug, it's the current behavior...

recompute the preview for each zoom level will take a while an gui will be difficult to use.

Gilles Caulier
Comment 2 Simon 2010-08-17 10:36:54 UTC 
Yes -- I did not mean it to recompute for every zoom level you go through while zooming in/out.

But when I zoom out to see the whole image, or zoom in to see how the effect effects a certain part, then I need to either change a curve node or click again on the «Original on mouse over» icon. Neither of them makes sense.
Comment 3 caulier.gilles 2011-12-18 17:16:25 UTC 
Simon,

This file still valid using digiKam 2.4 ?

Gilles Caulier
Comment 4 Simon 2012-06-13 15:50:33 UTC 
Yes.
Comment 5 caulier.gilles 2012-06-13 15:53:06 UTC 
And with last digiKam 2.6.0 just released ?

Gilles Caulier
Comment 6 Simon 2012-06-13 16:04:25 UTC 
Only have the beta3 here in the repository, but for this one, yes.
Comment 7 caulier.gilles 2012-06-13 16:05:08 UTC 
"yes", want mean fixed or not ?
Gilles Caulier
Comment 8 Simon 2012-06-13 16:06:13 UTC 
Means yes, still exists ;)
Comment 9 Marcel Wiesweg 2012-10-27 14:36:37 UTC 
The bug affects zooming with any mode of change preview (mouse over, side by side, after).
I believe auto-recomputation should be started by a timer.
Comment 10 caulier.gilles 2014-01-29 16:30:31 UTC 
Git commit 6394b9d53c4727c08f5b45c14f5f4871778db465 by Gilles Caulier.
Committed on 29/01/2014 at 16:29.
Pushed by cgilles into branch 'gsoc2013-editorcanvas'.

Canvas and ImageRegionWidget must be synchronized between editor toll sessions
FIXED-IN: 4.0.0

M  +11   -0    libs/widgets/graphicsview/graphicsdimgview.cpp
M  +5    -3    libs/widgets/graphicsview/graphicsdimgview.h
M  +21   -7    utilities/imageeditor/editor/editortooliface.cpp
M  +0    -5    utilities/imageeditor/widgets/canvas.cpp
M  +0    -8    utilities/imageeditor/widgets/canvas.h
M  +0    -6    utilities/imageeditor/widgets/imageregionwidget.cpp
M  +0    -2    utilities/imageeditor/widgets/imageregionwidget.h

http://commits.kde.org/digikam/6394b9d53c4727c08f5b45c14f5f4871778db465