Bug 246751

Summary:	Konqueror "restore tabs after crash" broken with webkit as default rendering engine
Product:	[Frameworks and Libraries] kwebkitpart	Reporter:	george panta <adgeruy>
Component:	general	Assignee:	webkit-devel
Status:	RESOLVED FIXED
Severity:	normal	CC:	adawit, dawan, frederic.coiffier, gkodadek, greenrd, matofesi
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description george panta 2010-08-05 01:09:25 UTC

Version:           unspecified (using KDE 4.4.95) 
OS:                Linux

(I have setup kwebkitpart as the default text/html viewer.)

Konqueror offers an option to restore tabs after crash. Normally with KHTML as default viewer every tab is restored.

However if kwebkitpart is set as default, tabs appear initially correct, yet finally every tab loads the URL of the last tab.

So you end up with the same URL in every tab.

Loading a previously saved session via the konq session manager works flawlessly.

Reproducible: Always

Steps to Reproduce:
killall konqueror
open konqueror and accept the restore tabs option.

Actual Results:  
Every tab loads the same url - all tabs are duplicate of the last.

Expected Results:  
Every tab is restored and loads the URL it should.

Tested with both kwebkitpart 0.9.6 and latest svn.

Comment 1 george panta 2010-08-05 09:29:47 UTC

It seems that every tab loads the url of the focused tab, ordering does not matter.

Comment 2 Dawit Alemayehu 2010-08-07 21:07:51 UTC

This is a known issue and is the result of the difficulty we have in integrating QtWebKit's history management with that of Konqueror's. Hopefully soon I will come up with a solution that will address this problem...

Comment 3 george panta 2010-08-07 22:39:24 UTC

I see. Thanks for the clarification and for your work on this.

Comment 4 Dawit Alemayehu 2010-08-26 07:22:10 UTC

SVN commit 1168104 by adawit:

- More fixes/workaround for the history syncing issues between QtWebKit and 
  Konqueror. This should improve restoration of content after crashes or any 
  other abnormal shutdown of the hosting application (read: Konqueror).

  There is one caveat, but it is caused by the way Konqueror works and not 
  kwebkitpart. For the details about the remaining issue, see link below:
  http://lists.kde.org/?l=kfm-devel&m=128275102319735&w=2.

BUG:246751


 M  +34 -25    kwebkitpart.cpp  
 M  +3 -1      kwebkitpart.h  
 M  +43 -31    kwebkitpart_ext.cpp  
 M  +3 -2      kwebkitpart_ext.h  
 M  +38 -5     kwebkitpart_p.cpp  
 M  +3 -1      kwebkitpart_p.h  
 M  +48 -2     kwebkitpartfactory.cpp  
 M  +10 -1     kwebkitpartfactory.h  
 M  +29 -15    webpage.cpp  
 M  +5 -6      websslinfo.cpp  
 M  +2 -2      websslinfo.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1168104

Comment 5 Dawit Alemayehu 2010-09-30 17:19:31 UTC

*** Bug 252837 has been marked as a duplicate of this bug. ***

Comment 6 Dawit Alemayehu 2010-11-28 22:13:33 UTC

*** Bug 258223 has been marked as a duplicate of this bug. ***

Comment 7 Dawit Alemayehu 2010-12-19 22:39:55 UTC

*** Bug 260709 has been marked as a duplicate of this bug. ***

Comment 8 Dawit Alemayehu 2011-11-17 01:04:51 UTC

*** Bug 250264 has been marked as a duplicate of this bug. ***

Comment 9 Dawit Alemayehu 2012-07-31 07:51:43 UTC

*** Bug 267335 has been marked as a duplicate of this bug. ***