Bug 246051

Summary:	untranslatable gui messages - missing tr/i18n calls + extraction in marble/src/plugins/runner/*
Product:	[Applications] marble	Reporter:	Burkhard Lück <lueck>
Component:	general	Assignee:	marble-bugs
Status:	RESOLVED FIXED
Severity:	normal	CC:	bastianholst, nienhueser
Priority:	NOR
Version:	unspecified
Target Milestone:	1.0 (KDE 4.6)
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Burkhard Lück 2010-07-28 17:20:10 UTC

Version:           unspecified (using Devel) 
OS:                Linux

In recent trunk + branch compiled from sources 35 messages in runner subdirs due to missing tr/i18n calls + extraction:

./nominatim/NominatimPlugin.cpp:22:    setName( "OSM Nominatim" );
./nominatim/NominatimPlugin.cpp:23:    setNameId( "nominatim" );
./nominatim/NominatimPlugin.cpp:24:    setDescription( "Searches for placemarks using the OpenStreetMap Nominatim service" );
./nominatim/NominatimPlugin.cpp:25:    setGuiString( "OpenStreetMap Nominatim Search" );
./gosmore/GosmorePlugin.cpp:22:    setName( "Gosmore" );
./gosmore/GosmorePlugin.cpp:23:    setNameId( "gosmore" );
./gosmore/GosmorePlugin.cpp:24:    setDescription( "Retrieves routes from gosmore" );
./gosmore/GosmorePlugin.cpp:25:    setGuiString( "Gosmore Routing" );
./gosmore/GosmoreRunner.cpp:108:    routePlacemark->setName( "Route" );
./yours/YoursPlugin.cpp:22:    setName( "Yours" );
./yours/YoursPlugin.cpp:23:    setNameId( "yours" );
./yours/YoursPlugin.cpp:24:    setDescription( "Retrieves routes from a yours server" );
./yours/YoursPlugin.cpp:25:    setGuiString( "Yours Routing" );
./hostip/HostipPlugin.cpp:22:    setName( "Hostip.info" );
./hostip/HostipPlugin.cpp:23:    setNameId( "hostip" );
./hostip/HostipPlugin.cpp:24:    setDescription( "Host name and IP geolocation search using the hostip.info service" );
./hostip/HostipPlugin.cpp:25:    setGuiString( "Hostip.info Search" );
./latlon/LatLonPlugin.cpp:20:    setName( "Geographic Coordinates" );
./latlon/LatLonPlugin.cpp:21:    setNameId( "latlon" );
./latlon/LatLonPlugin.cpp:22:    setDescription( "Direct input of geographic coordinates" );
./latlon/LatLonPlugin.cpp:23:    setGuiString( "Geographic Coordinates" );
./openrouteservice/OpenRouteServiceRunner.cpp:207:    result->setName( "OpenRouteService" );
./openrouteservice/OpenRouteServiceRunner.cpp:243:    routePlacemark->setName( "Route" );
./openrouteservice/OpenRouteServicePlugin.cpp:22:    setName( "OpenRouteService" );
./openrouteservice/OpenRouteServicePlugin.cpp:23:    setNameId( "openrouteservice" );
./openrouteservice/OpenRouteServicePlugin.cpp:24:    setDescription( "Retrieves routes from openrouteservice.org" );
./openrouteservice/OpenRouteServicePlugin.cpp:25:    setGuiString( "OpenRouteService Routing" );
./localdatabase/LocalDatabasePlugin.cpp:20:    setName( "Local Database" );
./localdatabase/LocalDatabasePlugin.cpp:21:    setNameId( "localdatabase" );
./localdatabase/LocalDatabasePlugin.cpp:22:    setDescription( "Searches the internal Marble database for placemarks" );
./localdatabase/LocalDatabasePlugin.cpp:23:    setGuiString( "Local database Search" );
./namefinder/NameFinderPlugin.cpp:22:    setName( "OSM Namefinder" );
./namefinder/NameFinderPlugin.cpp:23:    setNameId( "namefinder" );
./namefinder/NameFinderPlugin.cpp:24:    setDescription( "Searches for placemarks using the OpenStreetMap NameFinder service" );
./namefinder/NameFinderPlugin.cpp:25:    setGuiString( "OpenStreetMap NameFinder Search" );


Reproducible: Always

Comment 1 Bastian Senst 2010-10-11 16:42:40 UTC

This one seems to be fixed, isn't it?

Comment 2 Burkhard Lück 2010-10-11 17:52:39 UTC

(In reply to comment #1)
> This one seems to be fixed, isn't it?

Most strings in my list are extracted now, but what about these:

./traveling-salesman/TravelingSalesmanRunner.cpp:125:    routePlacemark->setName( "Route" );
./monav/MonavRunner.cpp:163:    routePlacemark->setName( "Route" );
./gosmore/GosmoreRunner.cpp:164:    routePlacemark->setName( "Route" );
./openrouteservice/OpenRouteServiceRunner.cpp:243:    routePlacemark->setName( "Route" );
./routino/RoutinoRunner.cpp:183:    routePlacemark->setName( "Route" );

Are they user visible and need a translation as well?

Comment 3 Dennis Nienhüser 2010-10-11 18:36:05 UTC

Currently they are not user visible and don't need a translation.
When changing that -- they may become user visible in the future -- the checks in RoutingModel and AlternativeRoutesModel need to be adjusted as well, possibly even the logic changed.