Summary: | Amarok crashing after replugin of ipod [@ Handler::IpodArtworkCapability::getCover] | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Bill King <bill.king> |
Component: | Collections/iPod iPhone | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | 123kash, abm272, blackouter, eric.erfanian, finsterbuschlucas, madcatx, manu.wagner, matej, optiluca, saslam101, teuf |
Priority: | NOR | ||
Version: | 2.4-GIT | ||
Target Milestone: | 2.4.0 | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 2.5 | |
Sentry Crash Report: |
Description
Bill King
2010-07-27 01:42:11 UTC
Seeing this in the git versions too. Bill, do you talk about current git of today? Bumping version. Any news on this? Confirmed by this comment: https://bugs.kde.org/show_bug.cgi?id=259647#c5 subscribing others *** Bug 263362 has been marked as a duplicate of this bug. *** *** Bug 268856 has been marked as a duplicate of this bug. *** *** Bug 270214 has been marked as a duplicate of this bug. *** *** Bug 271832 has been marked as a duplicate of this bug. *** *** Bug 284567 has been marked as a duplicate of this bug. *** I will take a look at this. Git commit f9ea65ed3031406a9553a28d5330c7b2ede44518 by Matěj Laitl. Committed on 26/10/2011 at 21:13. Pushed by laitl into branch 'master'. Mandatory QObject-based memory mngment for all MediaDevice Capabilities AFAICS, all subclasses of Handler::Capability were only created using "new" and never deleted, yielding continuous memory leaks. Make it compulsory for them to pass their parent object (relevant MediaDeviceHandler) so that they are deleted when their associated collections (and therefore handlers) disappear. Added benefit is that it is now guaranteed inside capabilities that their collection (handler) is valid throughout their lifetime. All external code that keeps references to such capabilities should do so only using QWeakPointer (all found places fixed). Apart from fixing memory leaks, this should definitely fix crash in bug 245852. Fix also MediaDeviceTrack::inCollection() so that other crashed are avoided. BUG: 245852 FIXED-IN: 2.5 M +1 -1 src/core-impl/collections/ipodcollection/handler/capabilities/IpodArtworkCapability.cpp M +1 -1 src/core-impl/collections/ipodcollection/handler/capabilities/IpodPlaylistCapability.cpp M +1 -1 src/core-impl/collections/ipodcollection/handler/capabilities/IpodReadCapability.cpp M +1 -1 src/core-impl/collections/ipodcollection/handler/capabilities/IpodWriteCapability.cpp M +15 -15 src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp M +2 -3 src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h M +7 -0 src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandlerCapability.h M +1 -0 src/core-impl/collections/mediadevicecollection/handler/capabilities/ArtworkCapability.h M +2 -1 src/core-impl/collections/mediadevicecollection/handler/capabilities/PlaylistCapability.h M +1 -0 src/core-impl/collections/mediadevicecollection/handler/capabilities/ReadCapability.h M +1 -0 src/core-impl/collections/mediadevicecollection/handler/capabilities/ReadCapabilityBase.h M +1 -0 src/core-impl/collections/mediadevicecollection/handler/capabilities/WriteCapability.h M +1 -0 src/core-impl/collections/mediadevicecollection/handler/capabilities/WriteCapabilityBase.h M +1 -1 src/core-impl/collections/mtpcollection/handler/capabilities/MtpPlaylistCapability.cpp M +1 -1 src/core-impl/collections/mtpcollection/handler/capabilities/MtpReadCapability.cpp M +1 -1 src/core-impl/collections/mtpcollection/handler/capabilities/MtpWriteCapability.cpp http://commits.kde.org/amarok/f9ea65ed3031406a9553a28d5330c7b2ede44518 *** Bug 289059 has been marked as a duplicate of this bug. *** *** Bug 294264 has been marked as a duplicate of this bug. *** |