| Summary: | Ark shows the file's name in the infopanel even when it isn't opened correctly | ||
|---|---|---|---|
| Product: | [Applications] ark | Reporter: | Raphael Kubo da Costa <rakuco> |
| Component: | general | Assignee: | Raphael Kubo da Costa <rakuco> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde, ozaruba, rakuco, simonandric5 |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/ark/03b6de3cfc7519d88c0c026a4a9737f5604d6a99 | Version Fixed In: | 4.14.1 |
| Sentry Crash Report: | |||
|
Description
Raphael Kubo da Costa
2010-07-25 04:53:34 UTC
Changing the default assignee in the currently open Ark bug reports to me. When working on this, one should remember to test opening header-protected archives with a wrong password (I'm considering bug 35371 will have been completely solved by then ;) Hi, I would like to work on this bug. Excellent :-) Please send a patch through ReviewBoard once you're done. Git commit 03b6de3cfc7519d88c0c026a4a9737f5604d6a99 by Raphael Kubo da Costa. Committed on 06/09/2014 at 16:05. Pushed by rkcosta into branch 'KDE/4.14'. Reset info panel and window caption when an archive fails to open. When opening an archive that for whatever reason fails to load (because it's corrupt, or an invalid format) the archive appears to be open when it is not in fact open. This patch fixes that by resetting the open archive, info panel name and window caption. Patch by Mathias Tillman <master.homer@gmail.com>, thank you! CCMAIl: master.homer@gmail.com FIXED-IN: 4.14.1 REVIEW: 120027 M +8 -0 part/part.cpp http://commits.kde.org/ark/03b6de3cfc7519d88c0c026a4a9737f5604d6a99 (In reply to Raphael Kubo da Costa from comment #6) > REVIEW: 120027 Should've been 120064, sorry. Prior to KDE 4.13.3, when opening a partial archive with ark, I would sometimes receive the warning message: Loading the archive /<path-to-file>/<filename>.part<n>.rar failed with the following error: Extraction failed because of an unexpected error. To which I would reply OK. Sometimes I would not receive the message. In either case, ark would then display the list of files in the archive to that point and their filesizes according to how much had downloaded. This would allow me to unpack and keep only the files I need, without downloading the entire archive, sometimes saving GiB of unnecessary download. Since upgrading to 4.13.3, which went smoothly, if I receive the warning message and reply OK, the information box is cleared, meaning no access to the files already downloaded. On partial archives that do not generate the warning message, all proceeds as before. Using rar from the command line, it is possible to list and test partial archives using the l and t commands. It is also possible to extract any file listed by the list function, with or without the resulting file sitting in the full archive path in the archive using the e or x commands. This means that Ark is no longer honouring rar's capabilities. The test for failure needs to parse the return codes more finely so that Ark honours rar's capabilities. For the record, I've spoken to David and we're tracking what he mentioned in comment 8 separately in bug 342859. |