Bug 245580

Summary: Dolphin advanced ACL editor silently fails if user does not have permission / options not grayed out
Product: [Unmaintained] kfile Reporter: bluescreenavenger
Component: kpropertiesdialogAssignee: kdelibs bugs <kdelibs-bugs>
Status: RESOLVED FIXED    
Severity: major CC: kde, sander, thomas.pfeiffer
Priority: NOR Keywords: usability
Version: 4.11.0Flags: kde: Usability+
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: http://commits.kde.org/kio/549fdb643b171952b5101ae0c7b9f80f361f3845 Version Fixed In:
Sentry Crash Report:

Description bluescreenavenger 2010-07-23 22:28:14 UTC 
Version:           unspecified (using Devel) 
OS:                Linux

When a user tries to change permissions on a folder they don't have access to change with the advanced POSIX ACL editor and hit OK, Dolphin silently fails, instead of telling the user that they don't have access to the folder. 

Reproducible: Always




OS: Linux (i686) release 2.6.35-6-generic
Compiler: cc
Comment 1 Janek Bevendorff 2012-09-07 14:04:04 UTC 
It does not only fail silently, the UI pretends it were possible to change the ACLs on those files/directories.
All options inside the "Advanced Permissions" dialog should be grayed out, including the labels for the "Set UID", "Set GID" and "Sticky" checkboxes (the checkboxes themselves are, but not the labels) as well as the ACL list and the add/edit/delete buttons on the right side.

I consider this a major usability issue.
Comment 2 Thomas Pfeiffer 2012-09-15 21:14:17 UTC 
(From the usability team): I agree that this is a big usability problem and I agree with the solution suggested by Janek. This definitely has to be fixed.
Comment 3 Sander van Grieken 2014-09-18 12:11:02 UTC 
still present in 4.14
Comment 4 bluescreenavenger 2016-03-17 00:52:37 UTC 
Still present in 15.08.2
Comment 5 David Edmundson 2016-04-07 23:44:59 UTC 
Git commit 549fdb643b171952b5101ae0c7b9f80f361f3845 by David Edmundson.
Committed on 07/04/2016 at 23:44.
Pushed by davidedmundson into branch 'master'.

Don't enable acl permissions widget if we don't own the file

The man page for setfacl says only the file owner or root can change the
permissions, so it would always fail. Better to disable it in the UI.
REVIEW: 127414

M  +1    -0    src/widgets/kpropertiesdialog.cpp

http://commits.kde.org/kio/549fdb643b171952b5101ae0c7b9f80f361f3845
Comment 6 David Edmundson 2016-04-07 23:44:59 UTC 
Git commit 36d80144ab9acf078deb0379e6aff3a912f5d3da by David Edmundson.
Committed on 07/04/2016 at 23:44.
Pushed by davidedmundson into branch 'master'.

Set text on QCheckbox widget rather than using a separate label

This fixes (amongst other focus changes) the label having the right
enabled effect if the permissions are not editable.
REVIEW: 127418

M  +18   -33   src/widgets/kpropertiesdialog.cpp

http://commits.kde.org/kio/36d80144ab9acf078deb0379e6aff3a912f5d3da