Bug 245478

Summary: "New Tab" menu opens a list with only one item
Product: [Applications] konsole Reporter: David Nemeskey <nemeskey.david>
Component: generalAssignee: Konsole Developer <konsole-devel>
Status: REOPENED ---    
Severity: normal CC: adaptee, francesco.cecconi, kde, rmarbertin, saulotoledo
Priority: LO    
Version: 22.12.3   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed In: 4.8
Sentry Crash Report:
Attachments: do not display "Default Profile" or the first user profile

Description David Nemeskey 2010-07-22 22:37:46 UTC 
Version:           2.5 (using Devel) 
OS:                Linux

The behavior of the "New Tab" menu item has apparently changed in 4.5 RC (2?). Before, clicking on it would simply open a new tab, which is I guess what everyone expects. As of 4.5 RC, this is not the case: a list opens, showing the types of tabs that can be opened. Actually, this is only an educated guess, considering the fact that it only shows one item, "Shell" for me.

Now, I strongly disagree with this kind of behavior, for the following reasons:
- If there is only one possible action, why should I waste another click (and the time to realize I _have_ to click something and move the pointer over)? If there would be only one item, the list is superfluous: the action should be executed, and the list should not appear.
- Even if there are more than one options, the menu item should still be pushable, and it should invoke the default action (most likely "Shell"). For those who want to do more fancy stuff, there is the list.
- If the behavior I just described is not feasible (I am not that acquinted with Qt), then make two menu items: "New Tab", which opens a new terminal tab, and "Open Special Tab" (or sth along that line), which shows the list.

Please consider my suggestions. The current behavior is annoying and is not certainly not sound usability-wise.

Reproducible: Always

Steps to Reproduce:
Just click on "New Tab".

Actual Results:  
Clicking on the "New Tab" menu opens a list with only one element.

Expected Results:  
No list should be opened if there is only one element in it.
Comment 1 Christoph Feck 2010-07-22 22:54:48 UTC 
Cannot reproduce on trunk. Clicking the "New Tab" button simply opens a new tab. Holding it shows the menu.
Comment 2 Christoph Feck 2010-07-22 22:57:48 UTC 
Ah sorry, you mean the menu item ... I never use those, I just use the button at the left of the tab bar (or double click into empty tab bar area).
Comment 3 David Nemeskey 2010-07-22 23:07:18 UTC 
(In reply to comment #2)
> Ah sorry, you mean the menu item ... I never use those, I just use the button
> at the left of the tab bar (or double click into empty tab bar area).

Can I take that as a confirmation? :)
Comment 4 Christoph Feck 2010-12-01 13:34:25 UTC 
*** Bug 258477 has been marked as a duplicate of this bug. ***
Comment 5 David Nemeskey 2010-12-05 10:36:46 UTC 
Still the same in 4.6 beta 1 :(
Comment 6 David Nemeskey 2010-12-05 10:38:35 UTC 
Actually, if a duplicate of this bug has been filed by someone else, shouldn't that count as a confirmation?
Comment 7 Christoph Feck 2011-01-27 14:46:01 UTC 
*** Bug 264402 has been marked as a duplicate of this bug. ***
Comment 8 Francesco Cecconi 2011-09-18 16:11:34 UTC 
Created attachment 63749 [details]
do not display "Default Profile" or the first user profile

Hi,
I have created a patch for this bug. :)

Best Regards,
Francesco
Comment 9 David Nemeskey 2011-09-18 16:36:12 UTC 
Francesco: Great! I'm looking forward to seeing it in action. :)

(In reply to comment #8)
> Created an attachment (id=63749) [details]
> do not display "Default Profile" or the first user profile
> 
> Hi,
> I have created a patch for this bug. :)
> 
> Best Regards,
> Francesco
Comment 10 Kurt Hindenburg 2011-09-18 21:27:04 UTC 
#8, thanks for the patch - it appears to work as expected.

If you have time, can you put patches on https://git.reviewboard.kde.org/dashboard/ w/ konsole group.
Comment 11 Kurt Hindenburg 2011-09-19 13:38:56 UTC 
The one issue I see is that if the user has only a non-default profile selected to show in menu, when clicked/triggered, the default profile is always called.
Comment 12 Kurt Hindenburg 2011-09-24 20:22:39 UTC 
Git commit 127c2b523ee2e75679d066cd8c399774ca37b990 by Kurt Hindenburg.
Committed on 24/09/2011 at 22:17.
Pushed by hindenburg into branch 'master'.

Don't show the default profile in list when no others are listed.

When user selects only 1 profile to be listed in menu, it makes the
'New Tab->' list unnecessary.  No profile will listed if the only
selected profile is the default one.

Patch by Francesco Cecconi <francesco.cecconi@gmail.com>

BUG: 245478
REVIEW: 102670
FIXED-IN: 4.8

M  +34   -14   src/MainWindow.cpp

http://commits.kde.org/konsole/127c2b523ee2e75679d066cd8c399774ca37b990
Comment 13 Alain Knaff 2023-11-12 10:59:00 UTC 
Still (again) an issue in 22.12.3

Now File->NewTab opens a menu with a single item "Built-in"

If Built-in is customized by user, it opens a menu with *2* items: the original "Built-in" and a second item with the users' customizations.

Both cases are wrong. In the second case, the users' customizations should overwrite and completely hide the original Built-in, and still not cause that submenu to appear.
Comment 14 Robert Martin 2024-03-08 05:51:46 UTC 
"it's a feature, not a bug". Adding a profile gives the "New Tab" sub-menu the items ["Built-in", "Profile 1"]. This confused me when my assigned new-tab keyboard shortcut wasn't working. 
It would be nice if "New Tab" wasn't a sub-menu to the actual actionables when this behavior isn't explicitly desired.