| Summary: | Image editor does not remember camera profile under Custom | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Sander <bugs> |
| Component: | Plugin-RawImport-Native | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugs, caulier.gilles |
| Priority: | NOR | ||
| Version: | 1.3.0 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 1.4.0 | |
| Sentry Crash Report: | |||
| Attachments: | proposed patch against revision 1153502 | ||
|
Description
Sander
2010-07-21 17:58:39 UTC
Try again with digiKam 1.3.0 Gilles Caulier 2010/7/21, Sander <bugs@sanderdekievit.nl>: > https://bugs.kde.org/show_bug.cgi?id=245336 > > Summary: Image editor does not remember camera profile under > Custom > Product: digikam > Version: 1.3.0 > Platform: Ubuntu Packages > OS/Version: Linux > Status: UNCONFIRMED > Severity: normal > Priority: NOR > Component: Image Editor > AssignedTo: digikam-devel@kde.org > ReportedBy: bugs@sanderdekievit.nl > > > Version: 1.3.0 (using KDE 4.4.4) > OS: Linux > > If I remember correctly, under digiKam 1.2.0 the image editor would remember > the camera profile that was set when decoding raw in the image editor: > ave > > The second step currently fails... > > Reproducible: Always > > Steps to Reproduce: > 1. Choose raw file > 2. Choose Edit > 3. Set camera profile > 4. Import > 5. Manipulations and save > 6. Open next raw file > 7. Set camera profile <-- here is where I expected the editor to remember > the > camera profile! > > > It fails in the step > > Actual Results: > Camera profile is set to none every time. > > Also, I found that even if I changed the profile, the setting under the > digikamrc file did not change: > Input Color Profile=$HOME/.iccprofiles/myprofile.icc > Input Color Space=2 > > These were the settings from digikam 1.2.0. Removing the file and setting it > up > again did not make this entry appear. > > Expected Results: > Expected result: Image Editor to remember the input profile > > In the file, I expected the Input Color Profile entry to change or appear. > > I am using Ubuntu 10.04. Bug is at least present in sources of 1.4.0 and in > the > version released on the website digikam.org > The version delivered with Ubuntu 10.04 (1.2.0) does not suffer from this > bug, > it seems. > > -- > Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email > ------- You are receiving this mail because: ------- > You are the assignee for the bug. > _______________________________________________ > Digikam-devel mailing list > Digikam-devel@kde.org > https://mail.kde.org/mailman/listinfo/digikam-devel > I am afraid you are mistaken on the version. I am using 1.3.0 (the one that are offered on the digikam.org website). I will try again using 1.2.0 and report back to you. If it does not work, I will try 1.4.0. I'll keep you posted. (In reply to comment #1) > Try again with digiKam 1.3.0 > > Gilles Caulier > > 2010/7/21, Sander <bugs@sanderdekievit.nl>: > > https://bugs.kde.org/show_bug.cgi?id=245336 > > > > Summary: Image editor does not remember camera profile under > > Custom > > Product: digikam > > Version: 1.3.0 > > Platform: Ubuntu Packages > > OS/Version: Linux > > Status: UNCONFIRMED > > Severity: normal > > Priority: NOR > > Component: Image Editor > > AssignedTo: digikam-devel@kde.org > > ReportedBy: bugs@sanderdekievit.nl > > > > > > Version: 1.3.0 (using KDE 4.4.4) > > OS: Linux > > > > If I remember correctly, under digiKam 1.2.0 the image editor would remember > > the camera profile that was set when decoding raw in the image editor: > > ave > > > > The second step currently fails... > > > > Reproducible: Always > > > > Steps to Reproduce: > > 1. Choose raw file > > 2. Choose Edit > > 3. Set camera profile > > 4. Import > > 5. Manipulations and save > > 6. Open next raw file > > 7. Set camera profile <-- here is where I expected the editor to remember > > the > > camera profile! > > > > > > It fails in the step > > > > Actual Results: > > Camera profile is set to none every time. > > > > Also, I found that even if I changed the profile, the setting under the > > digikamrc file did not change: > > Input Color Profile=$HOME/.iccprofiles/myprofile.icc > > Input Color Space=2 > > > > These were the settings from digikam 1.2.0. Removing the file and setting it > > up > > again did not make this entry appear. > > > > Expected Results: > > Expected result: Image Editor to remember the input profile > > > > In the file, I expected the Input Color Profile entry to change or appear. > > > > I am using Ubuntu 10.04. Bug is at least present in sources of 1.4.0 and in > > the > > version released on the website digikam.org > > The version delivered with Ubuntu 10.04 (1.2.0) does not suffer from this > > bug, > > it seems. > > > > -- > > Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email > > ------- You are receiving this mail because: ------- > > You are the assignee for the bug. > > _______________________________________________ > > Digikam-devel mailing list > > Digikam-devel@kde.org > > https://mail.kde.org/mailman/listinfo/digikam-devel > > No need to try with 1.2.0. I just see 1.2.0 in your report. My mistake. Gilles Caulier I've gone back to 1.2.0 (packaged with Ubuntu). It works there. In 1.3.0 (packaged on digikam.org) it doesn't work and in 1.4.0 (version from svn, today) it also doesn't work. Additionally, the setting also isn't set in the digikamrc file (so both saving and reading of this setting have the same problem.) Running in debug mode, I haven't found any errors related to not being able to find this setting or not being able to write this setting. The rawsettingsbox.cpp did seem to miss an entry for saving this setting. However, I had no idea how to add, so I couldn't test it for you. I hope this helps! This is the code relevant : RAW decoding setting widget instance : http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/rawimport/rawsettingsbox.cpp#178 Read and Save settings call : http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/rawimport/rawsettingsbox.cpp#442 http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/rawimport/rawsettingsbox.cpp#464 Which call these methods : http://lxr.kde.org/source/KDE/kdegraphics/libs/libkdcraw/libkdcraw/dcrawsettingswidget.cpp#933 http://lxr.kde.org/source/KDE/kdegraphics/libs/libkdcraw/libkdcraw/dcrawsettingswidget.cpp#940 ...and finally : http://lxr.kde.org/source/KDE/kdegraphics/libs/libkdcraw/libkdcraw/rawdecodingsettings.cpp#209 http://lxr.kde.org/source/KDE/kdegraphics/libs/libkdcraw/libkdcraw/rawdecodingsettings.cpp#236 And the bug is there : where is the call to these last both method to read and write input color space settings... Sound like i miss to write these lines... Note : why 1.2.0 and 1.3.0 do not give the same result ? because i factorized a lots API. You can see many methods which are now deprecated : http://lxr.kde.org/source/KDE/kdegraphics/libs/libkdcraw/libkdcraw/dcrawsettingswidget.h#130 So the fix is very simple to do in rawdecodingsettings.cpp. Do you able to manage a patch against svn trunk ? (:=))) Gilles Caulier > https://bugs.kde.org/show_bug.cgi?id=245336
>
Sure, I will give it a try tomorrow.
Created attachment 49454 [details]
proposed patch against revision 1153502
SVN commit 1153997 by cgilles: apply patch #49454 from sander dekievit BUGS: 245336 M +6 -0 rawdecodingsettings.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1153997 Thanks Sanders form our patch. Congratulations about your blog entries to compare Aperture and digiKam. I'm impatient to read the next stage of your words... Gilles Caulier |