Bug 245123

Summary:	Some Holidays for Austria wrong
Product:	[Applications] kdepimlibs	Reporter:	Stefan Derkits <stefan>
Component:	kholidays	Assignee:	John Layt <jlayt>
Status:	RESOLVED FIXED
Severity:	normal	CC:	hanspeterg, j.mairboeck, jlayt, kevin.kofler
Priority:	NOR
Version:	4.5
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:

Description Stefan Derkits 2010-07-19 12:49:06 UTC

Version:           4.5 (using Devel) 
OS:                Linux

Some of the Holiday Entries for Austria are wrong.
In File http://websvn.kde.org/trunk/KDE/kdepimlibs/kholidays/holidays/plan2/holiday_at_de?revision=1131669&view=markup

Wrong Holidays:
"Allerseelen" on december 2
"Martini" on december 11
"Leopoldi" on december 15 

Correct:
"Allerseelen" on november 2 [category should be religious]
"Martini" on november 11 [only a Holiday in Burgenland, one of the Regions in Austria, in the Rest just a "Cultural" Holiday]
"Leopoldi" on november 15 [only a Holiday in Vienna, Lower Austria & Upper Austria]

Reproducible: Always

Comment 1 Joachim Mairböck 2010-09-22 18:13:45 UTC

Confirmed in KDE SC 4.5.1 with digital clock plasmoid.

Comment 2 John Layt 2010-09-22 20:29:29 UTC

SVN commit 1178327 by jlayt:

Fixes to Austrian holiday file

CCBUG: 245123



 M  +47 -16    holiday_at_de  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1178327

Comment 3 John Layt 2010-09-22 20:31:12 UTC

I've fixed those issues and a few others according to Wikipedia (full names, etc), could you please check the trunk version at http://websvn.kde.org/trunk/KDE/kdepimlibs/kholidays/holidays/plan2/holiday_at_de?view=markup before I backport to 4.5?

Thanks!

Comment 4 Hans-Peter Guggenbichler 2010-10-31 22:56:42 UTC

Hi, 
I can confirm that austrian holiday file, as pointed ot in comment #3, is correct. However, the first section seems a bit misleading to me. New years day, for example is not on "weekend on January 1", it is on January 1.

Comment 5 John Layt 2010-11-01 00:00:33 UTC

Thanks Hans-Peter.  The 'weekend' part is just a hang-over from the file format being 'borrowed' from some project planning software, we just use the keyword 'weekend' to mean a day off.  We plan a new XML format at some stage, possibly in 4.7.

I'll backport to 4.5 soon.

Comment 6 Kevin Kofler 2010-11-10 21:56:13 UTC

Ping? This is still not fixed in the 4.5 branch.

Comment 7 Kevin Kofler 2010-11-10 22:04:17 UTC

(And what makes this particularly annoying is that now is the period of the year where those misplaced holidays are.)

Comment 8 John Layt 2010-11-12 10:54:28 UTC

SVN commit 1195915 by jlayt:

Backport Austrian holiday file fixes.

BUG: 245123



 M  +47 -16    holiday_at_de  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1195915