Bug 244911

Summary:	Run-together words never skipped
Product:	[Applications] kmail2	Reporter:	Sabine Faure <sabine>
Component:	composer	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED UNMAINTAINED
Severity:	normal	CC:	adrian, faure, montel
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Sabine Faure 2010-07-17 00:02:27 UTC

Version:           unspecified (using Devel) 
OS:                Linux

Run-together words are still underlined by the spellchecker after the 'Skip run-together words' check box has been checked.


Reproducible: Always

Steps to Reproduce:
- Launch Kontact and go to Kmail
- Click on 'New Message'
- Go to Settings menu/Spellchecker...
- Leave the Default language as English
- Uncheck all the check boxes (if any are checked)
- Click on 'Ok'
- In the composer text edit type the following lines:
'This file is top-secret.
This file is top-secre.'
- 'Top-secret' is not underlined but 'top-secre' is by the spellchecker
- Go back to Settings menu/Spellchecker...
- Check the 'Skip run-together words' check box only
- Click on 'Ok'






Actual Results:  
'top-secre' is still underlined eventhough the 'Skip run-together words' check box has been checked.

Expected Results:  
No run-together words should be underlined by the spellchecker.

Trunk, Svn Rev 1150720

Comment 1 Laurent Montel 2010-07-19 15:09:05 UTC

run-together fixed in svn
(a run-together word is a word with UpperCase in word)

Comment 2 David Faure 2010-07-22 23:12:30 UTC

It looks like I was wrong, run-together words can also have no uppercase letters in them. See the examples at http://aspell.net/0.50-doc/man-html/7_Adding.html#run-together
Same happens in german, see Donaudampfschiffahrtsgesellschaftskapitän (http://german.about.com/library/blwort_long.htm)

The problem IMHO is that this isn't sonnet's job, but the spellchecker's job. When "skip run-together words" is set, sonnet should set the corresponding option in aspell/ispell/hspell.

Comment 3 David Faure 2010-07-22 23:24:21 UTC

Also, with the current code, AaBbCc would be considered valid, but it's not "run together words", so it should be flagged invalid.

Comment 4 Sabine Faure 2010-07-22 23:29:13 UTC

Indeed after looking up the proper definition for run-together words here are the new steps to reproduce:

- Launch Kontact and go to Kmail
- Click on 'New Message'
- Go to Settings menu/Spellchecker...
- Leave the Default language as English
- Uncheck all the check boxes (if any are checked)
- Click on 'Ok'
- In the composer text edit type the following lines:
'youtube.com
Donaudampfschiffahrtsgesellschaftskapitän'
- Both words are underlined by the spellchecker
- None of the words should be underlined by the spellchecker.

Trunk, Svn Rev 1153123

- Go back to Settings menu/Spellchecker...
- Check the 'Skip run-together words' check box only
- Click on 'Ok'

Comment 5 Laurent Montel 2010-07-23 11:10:00 UTC

David it's right it's a job for aspell and not sonnet.
But with this api we can't easily to change it.
Will look at it.

Comment 6 Adrián Chaves (Gallaecio) 2012-09-18 06:29:56 UTC

Any news?

Comment 7 Denis Kurz 2016-09-24 18:06:53 UTC

This bug has only been reported for versions before 4.14, which have been unsupported for at least two years now. Can anyone tell if this bug still present?

If noone confirms this bug for a Framework-based version of kmail2 (version 5.0 or later, as part of KDE Applications 15.12 or later), it gets closed in about three months.

Comment 8 Denis Kurz 2017-01-07 21:42:06 UTC

Just as announced in my last comment, I close this bug. If you encounter it again in a recent version (at least 5.0 aka 15.08), please open a new one unless it already exists. Thank you for all your input.