Bug 244555

Summary:	Double tags in the list of "My Tags"
Product:	[Applications] amarok	Reporter:	Rindert Vonk <rindertvonk>
Component:	Services/Last.fm	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dmeltzer.devel, kde, lfranchi, matej
Priority:	NOR
Version:	2.5-git
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:	http://commits.kde.org/amarok/fb28edf000e2d4ed32f6c0c57701400a97a57c92	Version Fixed In:	2.7
Sentry Crash Report:
Attachments:	Screenshot of Tags list screenshot of last.fm "my tags" Last.fm My Tags station

Description Rindert Vonk 2010-07-14 01:40:14 UTC

Version:           2.3.1 (using KDE 4.4.4) 
OS:                Linux

In the list of the "My tags" some tags I get a double entry. The first part of the list is ok. These are tags with a lot of uses. But when a tag is less used the tag is show multiple times. With me it happens at count 10.
The complete count of all tags is correct. I've got 53 tags in my profile on last.fm and 53 in the list.
To make things clear I've added a screen shot.


Reproducible: Always




OS: Linux (x86_64) release 2.6.34-020634-generic
Compiler: cc

Comment 1 Rindert Vonk 2010-07-14 01:42:12 UTC

Created attachment 49134 [details]
Screenshot of Tags list

Comment 2 Valorie Zimmerman 2010-07-14 01:51:36 UTC

Created attachment 49135 [details]
screenshot of last.fm "my tags"

Comment 3 Valorie Zimmerman 2010-07-14 01:52:33 UTC

Comment on attachment 49135 [details]
screenshot of last.fm "my tags"

Confirmed in latest GIT, build a couple of hours ago.

Comment 4 Myriam Schweingruber 2010-07-14 10:32:42 UTC

Confirmed by second reporter.

Comment 5 Myriam Schweingruber 2011-05-07 09:40:38 UTC

Is this still valid with Amarok 2.4.1, to be released tomorrow?

Comment 6 Valorie Zimmerman 2011-06-17 00:09:32 UTC

Created attachment 61062 [details]
Last.fm My Tags station

Yes, the bug still exists in Git built today.

Comment 7 Myriam Schweingruber 2011-06-17 09:49:44 UTC

Thank you for the feedback :)

Comment 8 Matěj Laitl 2012-12-15 22:23:44 UTC

Git commit fb28edf000e2d4ed32f6c0c57701400a97a57c92 by Matěj Laitl.
Committed on 15/12/2012 at 23:14.
Pushed by laitl into branch 'master'.

LastFmTreeModel: big cleanup; triggered by Mamarok-detected sloppy view behaviour

Also remove WeightedString, it wasn't needed at all in fact.

BUGFIXES:
 * Fix incorrect display of Last.fm tags and other items.
FIXED-IN: 2.7

M  +4    -0    ChangeLog
M  +2    -2    src/services/lastfm/LastFmService.cpp
M  +290  -272  src/services/lastfm/LastFmTreeModel.cpp
M  +16   -32   src/services/lastfm/LastFmTreeModel.h
D  +0    -45   src/services/lastfm/WeightedString.h
D  +0    -67   src/services/lastfm/WeightedStringList.h

http://commits.kde.org/amarok/fb28edf000e2d4ed32f6c0c57701400a97a57c92