Bug 244008

Summary:	[PATCH] Make win32 implementation of KIO::stat report error if the file does not exists
Product:	[Unmaintained] kde-windows	Reporter:	Konstantin Savenkov <savenkov>
Component:	network and files	Assignee:	KDE-Windows <kde-windows>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	nate, ps_ml, rakuco
Priority:	NOR	Keywords:	triaged
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Microsoft Windows
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	patch to fix the bug

Description Konstantin Savenkov 2010-07-09 09:45:51 UTC

Version:           SVN (using Devel) 
OS:                MS Windows

Current implementation of KIO::stat job for MS Windows (based on QFileInfo) differs from the Unix one (based on KDE_lstat). In particular, it uses custom createUDSEntryWin function, which does not check if the file exists before building the UDSEntry.

That causes a lot of problems. For instance, in KDevelop app, existence of config files is checked via KIO::stat before creation of the files, so they are never created.

The fix changes interface of createUDSEntryWin to its Unix analogue, making it return bool: true if the file exists and false if it doesn't. QFileInfo::exists() is used to perform the check.

Reproducible: Always

Steps to Reproduce:
Create KIO::stat job for non-existing file, register end execute it. See true is returned.

Comment 1 Konstantin Savenkov 2010-07-09 09:47:16 UTC

Created attachment 48710 [details]
patch to fix the bug

Comment 2 Nate Graham 2017-12-01 17:13:19 UTC

Thanks for the patch! Unfortunately, as you have experienced, patches in Bugzilla tickets tend to be overlooked. If this patch is still relevant for KDE Frameworks 5, can you submit it using http://phabricator.kde.org/? Thanks!

Comment 3 Andrew Crouthamel 2018-09-28 02:44:25 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

Comment 4 Andrew Crouthamel 2018-10-28 03:14:17 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!