| Summary: | smoke/qtgui build failure against qt-4.7 | ||
|---|---|---|---|
| Product: | [Unmaintained] bindings | Reporter: | Rex Dieter <rdieter> |
| Component: | general | Assignee: | kde-bindings |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kevin.kofler |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Rex Dieter
2010-07-08 20:24:39 UTC
could you post that failing x_20.cpp file? I can attach it here too if you want (it's quite large though) These entries come from qs60style.h, which is used by the extractor, but not included. I think that header should be blacklisted. Hmmm, how do I blacklist that stuff? I tried this: http://cvs.fedoraproject.org/viewvc/rpms/kdebindings/devel/kdebindings-4.4.92-qt47.patch?revision=1.2&view=markup but it doesn't work. :-( This patch works: http://cvs.fedoraproject.org/viewvc/rpms/kdebindings/devel/kdebindings-4.4.92-qt47.patch?revision=1.6&view=markup I had to fix the generator to honor the blacklists also for global enums. I'm not sure all the modules I added the blacklist to need it: after adding it to qtgui and qtsvg and having the build fail on qtopengl, I got fed up of adding the stuff to every module one by one and just added it to everything inheriting qtgui. And then I also had to add it to qtmultimedia which doesn't inherit qtgui in the Smoke configuration, but still picks the stuff up somehow. Blacklisting isn't the way to go in this case. There's probably a QT_NO_S60STYLE define somewhere that we don't test for. Could someone check what this #define is called? Then I can add it to the QtGuess script. Looks like it's QT_NO_STYLE_S60. But interestingly, this commit from July 1: http://qt.gitorious.org/qt/qt/commit/8c14529abdbbaa32c7d4f9d84b97515ab759223e makes the style always compiled (possibly as a stub) and the enum always defined, which is why I haven't figured that out already. This means the next (after beta2) Qt is probably going to work without workarounds. But adding QT_NO_STYLE_S60 to QtGuess.txt looks like the way to go. SVN commit 1147833 by arnorehn: Test for QT_NO_STYLE_S60. BUG: 243971 M +2 -1 QtGuess.txt M +10 -0 tests/test.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1147833 SVN commit 1147834 by arnorehn: Test for QT_NO_STYLE_S60. BUG: 243971 M +2 -1 QtGuess.txt M +10 -0 tests/test.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1147834 I can confirm that your fix works: http://koji.fedoraproject.org/koji/buildinfo?buildID=182717 Thanks! |