Bug 243922

Summary:	Regression: Password in settings not remembered for mail check - because wallet receives invalid window ID when the systray icon is not running.
Product:	[Frameworks and Libraries] Akonadi	Reporter:	Thomas McGuire <mcguire>
Component:	POP3 Resource	Assignee:	Casey Link <unnamedrambler>
Status:	RESOLVED FIXED
Severity:	normal	CC:	adam, ashl1future, kdepim-bugs, unnamedrambler, vkrause
Priority:	NOR	Keywords:	akonadi-ports-regression
Version:	4.5
Target Milestone:	---
Platform:	Unlisted Binaries
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Thomas McGuire 2010-07-08 10:03:44 UTC

Entering a password in the settings dialog no longer seems to have any effect, after confirming the settings dialog and then doing a mail check I'm asked for the password again.

Comment 1 Casey Link 2010-07-11 17:17:02 UTC

The resource incorrectly set a flag to prompt the user again after the configure dialog was closed. This is easily fixed, however, it reveals another bug.

Opening of the wallet fails, because the WId returned by winIdForDialogs() isn't accepted by KWallet:

KWallet::Wallet::openWallet: Pass a valid window to KWallet::Wallet::openWallet().

The result is the user is prompted for the password again! Not sure whats going on here.

Comment 2 Casey Link 2010-07-11 17:20:59 UTC

SVN commit 1148685 by link:

Don't set the "Ask Again" flag to true after a the config dialog is closed. If the user did indeed change the password, it will be loaded from the wallet.

This reveals another bug, namely that the WId returned by winIdForDialogs() isn't accepted by KWallet. See bug.

CCBUG: 243922

 M  +0 -1      pop3resource.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1148685

Comment 3 Casey Link 2010-07-13 01:16:11 UTC

From IRC today:

<tokoe> casey: hmm, the winIdForDialogs() might change when some application is opened/closed... have to check that...
<tokoe> casey: ahh, it takes the winid from the systemtrayicon, which i haven't running...
<casey> tokoe: hm neither do i 
<tokoe> volker: do we require to have the akonadisystray running?
<volker> I don't think so
<tokoe> volker: if not, wallet integration seems to be kind of a problem, since we have no window id that kwallte can remeber to not ask the user over and over again

Summary: WId comes from systray icon, and thus is invalid if the icon is not running. 

Thoughts?

Comment 4 Till Adam 2010-07-13 12:39:20 UTC

Discussed this with Volker today, we think we should separate the two concerns here. 1) there should be an akonadi wide ID that is used for the wallet identification, independent of GUI processes. 2) every gui process that calls "needsWorkingAkonadi" should add its pid to a list of available window parents, and then the top most of those (or some other heuristic) should be used when a resource needs to raise a wallet dialog. There's already API in resourcebase to find out a win id to use as a parent.

Comment 5 Thomas McGuire 2010-12-24 19:21:07 UTC

The original bug here has been fixed (it works for me now), so closing this bug report.
Not sure what the issue about window IDs is about, but that should be a separate Akonadi-wide bug report.