Summary: | Cancel transaction edit dialog gives wrong options when you click on something other than another transaction | ||
---|---|---|---|
Product: | [Applications] kmymoney | Reporter: | Jack <ostroffjh> |
Component: | general | Assignee: | KMyMoney Devel Mailing List <kmymoney-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | algolix, lwilpan, ralf.habacker, tbaumgart |
Priority: | NOR | Flags: | tbaumgart:
Version_5-
|
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kmymoney/54e8c59279a75530907dce4faa1292bf1be67d79 | Version Fixed In: | 4.8.2 |
Description
Jack
2010-07-04 23:12:54 UTC
Just a quick note so I don't forget it: Canceling and returning will be hard if you open a menu, as KMyMoney is not in control of things anymore. I just noticed that this appears to happen for any transaction edit, not just a new transaction. Regarding the issue with KMM not always being able to continue - can you tell whether or not this is the case? If so, then the message could be altered. To me, the problem is that the dialog says you can save, quit, or return/cancel, but there isn't always a cancel button. In cases where you can't return, it's OK to not have a cancel button, but the dialog should not say there is one if there really is not. This same behavior has been bothering me for some time, except the "click the 'x'" workaround doesn't work for me. Simply closing the dialog box is equivalent to clicking "No"; that is, it closes and saves the transaction. This is a real annoyance when I accidentally click somewhere else while editing a transaction, as I have no option to continue editing. I am running KMM 4.5.3. About this case:
> In the ledger (I've confirmed the same behavior in a checking and an investment account) click on the blank row at the bottom to start entering a new transaction. If you then click on another transaction in the ledger, you get the cancel transaction edit dialog.
I think, this warning should appears, only if user input some data into the
fields (date, count, etc). As for me, it's not rare situation, when i click
to the new line and then click back to the existing line, without changes.
It's annoying and strange to cancel "nothing". I understand, that somewhere
in code some data structure is filled by current date and may be, some
default states, but logic of operator==(default_state_for_empty_fields,
current_state) is not correct.
And i don't want to set "forget" checkpoint, because, in regular situations
this warning is important.
That would help, but this behavior bothers me most when I am in the middle of editing a transaction and have changes that I don't want to be saved (e.g. I haven't deleted the check number yet for a non-check transaction). Issue is still present in version 4.8.0. Based on Comment #1 and my memory (since I haven't triggered this issue recently) I believe this is most common (and perhaps most annoying) when you click somewhere where it is KDE interrupting things, and not KMyMoney, so KMM doesn't really have enough control and doesn't know where you clicked. If that's true, I'm not sure there is much we can do except improve the wording of the message. Git commit 54e8c59279a75530907dce4faa1292bf1be67d79 by Ralf Habacker. Committed on 01/01/2018 at 21:46. Pushed by habacker into branch '4.8'. Fix 'Cancel transaction edit dialog gives wrong options ...' ... when you click on something other than another transaction. This commit enables the "continue" button in those cases. If the user wants to continue the transaction edit, cancels the event in MousePressFilter::eventFilter by returning true. FIXED-IN:4.8.2 M +3 -1 kmymoney/views/kgloballedgerview.cpp https://commits.kde.org/kmymoney/54e8c59279a75530907dce4faa1292bf1be67d79 |